[wpt-sync] Sync PR 24444 - [FragmentItem] Fix DirtyLinesFromNeedsLayout
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 24444 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/24444
Details from upstream follow.
Koji Ishii <kojii@chromium.org> wrote:
[FragmentItem] Fix DirtyLinesFromNeedsLayout
This patch fixes a case where |DirtyLinesFromNeedsLayout|
fails to mark items dirty for reusing cached lines.When searching for |LayoutObject| needing layout, checking
|NormalChildNeedsLayout| and |PosChildNeedsLayout| were not
enough. In some specific cases, only
|NeedsSimplifiedNormalFlowLayout| was set for the parent
inline box.This patch changes the condition to check descendants to
|NeedsLayout|.Bug: 1101883
Change-Id: Ia73ace058c9ea1ebaaffdaff793b56d68099cd5cReviewed-on: https://chromium-review.googlesource.com/2281781
WPT-Export-Revision: 34e0adaebeb3a54b257443b252b1f3eefa576ffb
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=446e3d035e5c24f77b5b40d87998b0c74c6fe0dc
Assignee | ||
Comment 2•4 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 1 subtests
Status Summary
Firefox
OK : 1
PASS: 1
Chrome
OK : 1
PASS: 1
Safari
OK : 1
PASS: 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/943bcc49c64c [wpt PR 24444] - [FragmentItem] Fix DirtyLinesFromNeedsLayout, a=testonly
Comment 4•4 years ago
|
||
bugherder |
Description
•