Closed Bug 1650676 Opened 7 months ago Closed 7 months ago

Port bug 1618798 - Remove nsIFocusManager::SetActiveWindow and JS callers thereof

Categories

(Thunderbird :: Add-Ons: Extensions API, defect)

defect

Tracking

(thunderbird_esr78 fixed, thunderbird79 fixed)

RESOLVED FIXED
Thunderbird 80.0
Tracking Status
thunderbird_esr78 --- fixed
thunderbird79 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Services.focus.activeWindow is now read-only. We only use it in one place:

setting getter-only property "activeWindow" ext-windows.js:299

Somebody had better review this, even though I'm going to land it now.

Attachment #9161496 - Flags: review?(khushil324)

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/60b7dcfa1162
Port bug 1618798 - Remove nsIFocusManager::SetActiveWindow and JS callers. rs=me

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Regressed by: 1618798
Target Milestone: --- → Thunderbird 80.0
Comment on attachment 9161496 [details] [diff] [review]
1650676-set-activewindow.diff

Review of attachment 9161496 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #9161496 - Flags: review?(khushil324) → review+
Comment on attachment 9161496 [details] [diff] [review]
1650676-set-activewindow.diff

This is just a minor fix but getting it into 78.1 will be good for extension developers.
Attachment #9161496 - Flags: approval-comm-esr78?
Attachment #9161496 - Flags: approval-comm-beta?
Comment on attachment 9161496 [details] [diff] [review]
1650676-set-activewindow.diff

Approved for 79 beta, to prepare for 78
Attachment #9161496 - Flags: approval-comm-beta? → approval-comm-beta+
Comment on attachment 9161496 [details] [diff] [review]
1650676-set-activewindow.diff

Approved for esr78
Attachment #9161496 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.