Closed
Bug 1650676
Opened 6 years ago
Closed 6 years ago
Port bug 1618798 - Remove nsIFocusManager::SetActiveWindow and JS callers thereof
Categories
(Thunderbird :: Add-Ons: Extensions API, defect)
Thunderbird
Add-Ons: Extensions API
Tracking
(thunderbird_esr78 fixed, thunderbird79 fixed)
RESOLVED
FIXED
Thunderbird 80.0
People
(Reporter: darktrojan, Assigned: darktrojan)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
1.20 KB,
patch
|
khushil324
:
review+
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
Services.focus.activeWindow is now read-only. We only use it in one place:
setting getter-only property "activeWindow" ext-windows.js:299
| Assignee | ||
Comment 1•6 years ago
|
||
Somebody had better review this, even though I'm going to land it now.
Attachment #9161496 -
Flags: review?(khushil324)
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/60b7dcfa1162
Port bug 1618798 - Remove nsIFocusManager::SetActiveWindow and JS callers. rs=me
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
| Assignee | ||
Updated•6 years ago
|
status-thunderbird79:
--- → affected
status-thunderbird_esr78:
--- → affected
Regressed by: 1618798
Target Milestone: --- → Thunderbird 80.0
Comment 3•6 years ago
|
||
Comment on attachment 9161496 [details] [diff] [review]
1650676-set-activewindow.diff
Review of attachment 9161496 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #9161496 -
Flags: review?(khushil324) → review+
| Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 9161496 [details] [diff] [review]
1650676-set-activewindow.diff
This is just a minor fix but getting it into 78.1 will be good for extension developers.
Attachment #9161496 -
Flags: approval-comm-esr78?
Attachment #9161496 -
Flags: approval-comm-beta?
Comment 5•6 years ago
|
||
Comment on attachment 9161496 [details] [diff] [review]
1650676-set-activewindow.diff
Approved for 79 beta, to prepare for 78
Attachment #9161496 -
Flags: approval-comm-beta? → approval-comm-beta+
| Assignee | ||
Comment 6•6 years ago
|
||
| bugherder uplift | ||
Thunderbird 79.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/c8ed3cbea7a4
| Assignee | ||
Updated•6 years ago
|
Comment 7•6 years ago
|
||
Comment on attachment 9161496 [details] [diff] [review]
1650676-set-activewindow.diff
Approved for esr78
Attachment #9161496 -
Flags: approval-comm-esr78? → approval-comm-esr78+
Comment 8•6 years ago
|
||
| bugherder uplift | ||
Thunderbird 78.0.1:
https://hg.mozilla.org/releases/comm-esr78/rev/d1273b332b36
You need to log in
before you can comment on or make changes to this bug.
Description
•