Closed Bug 1650732 Opened 5 years ago Closed 5 years ago

Store extra vCard values in nsIAbCard

Categories

(Thunderbird :: Address Book, enhancement)

Product:
Thunderbird
Component:
Address Book
Type:
enhancement

Tracking

(thunderbird_esr78 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 80.0
Tracking Flags:
Tracking Status
thunderbird_esr78 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(1 file)

1650732-vcard-extra-props-1.diff
7.20 KB, patch
mkmelin
: review+
wsmwk
: approval-comm-esr78+
Details | Diff | Splinter Review

vCard name and address properties have some fields that nsIAbCard doesn't explicitly have (although any property name is theoretically usable). Initially I decided not to store the information from these fields and just never overwrite it, but this is proving problematic. Instead, I'm going to store the fields in new properties on nsIAbCard, even though there is no UI to access them.

Attachment #9161534 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9161534 [details] [diff] [review] 1650732-vcard-extra-props-1.diff Review of attachment 9161534 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9161534 - Flags: review?(mkmelin+mozilla) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/274b38569035
Store extra vCard values in nsIAbCard. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
status-thunderbird_esr78: --- → affected
Target Milestone: --- → Thunderbird 80.0
Attachment #9161534 - Flags: approval-comm-esr78?

Comment on attachment 9161534 [details] [diff] [review]
1650732-vcard-extra-props-1.diff

[Triage Comment]
Approved for esr78

Attachment #9161534 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: