Closed Bug 1650739 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24453 - [FragmentItem] Limit reusing cached lines only when top-level child is clean

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24453 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24453
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[FragmentItem] Limit reusing cached lines only when top-level child is clean

This patch simplifies |DirtyLinesFromNeedsLayout| to check
|NeedsLayout| of top-level children only.

The previous code tried to reuse more lines, e.g.:
\<div>\<span>many lines of text\</span>\</div>
Most lines are reusable when appending to the end of "text".
But supporting this case complicates the logic, especially
when culled inline is involved.

The new logic can't reuse lines in the above case, but still
can reuse liens if the \<span> does not exist, and should
cover most common cases.

Bug: 1102083
Change-Id: I4f76e154b834c8c00e5ce04ab251c4f1fcdabab0

Reviewed-on: https://chromium-review.googlesource.com/2282821
WPT-Export-Revision: b929d5ba9d28b40997da2660f0e479596d634c16

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0110e577b7f
[wpt PR 24453] - [FragmentItem] Limit reusing cached lines only when top-level child is clean, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d0110e577b7f

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.