Closed Bug 1650797 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24458 - Portals: Support default click-to-activate.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox80 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24458 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24458
Details from upstream follow.

Jeremy Roman <jbroman@chromium.org> wrote:

Portals: Support default click-to-activate.

This adds a default behavior whereby clicking (or equivalent) will cause
the portal to immediately activate, unless the click or DOMActivate
event has preventDefault called by a listener.

This is guarded by a new runtime enabled feature so that this does not
affect the behavior in the current origin trial.

Bug: 1102081
Change-Id: I6a6c2409b0123f95d5068c54a423ac2f29e3e968
Reviewed-on: https://chromium-review.googlesource.com/2281308
WPT-Export-Revision: 461c43620c00ea50e7c054b2a852f41eb20d9038

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 2 subtests

Status Summary

Firefox

OK : 2
FAIL: 9

Chrome

OK : 2
FAIL: 9

Safari

OK : 2
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/portals/portals-focus.sub.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
test that an element inside a portal's x-origin subframe cannot steal focus: FAIL (Chrome: FAIL, Safari: FAIL)
test that an element inside a portal cannot steal focus: FAIL (Chrome: FAIL, Safari: FAIL)
test that a x-origin iframe inside an adopted portal cannot steal focus: FAIL (Chrome: FAIL, Safari: FAIL)
test that an element inside an adopted portal cannot steal focus: FAIL (Chrome: FAIL, Safari: FAIL)
test that a portal is keyboard focusable: FAIL (Chrome: FAIL, Safari: FAIL)
test that we cannot tab into a portal's contents: FAIL (Chrome: FAIL, Safari: FAIL)
test that a portal is keyboard activatable: FAIL (Chrome: FAIL, Safari: FAIL)
/portals/portal-activate-default.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Clicking shouldn't activate if prevented.: FAIL (Chrome: FAIL, Safari: FAIL)
Clicking should activate.: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/portals/portals-focus.sub.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/portals/portal-activate-default.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8acdcd226330
[wpt PR 24458] - Portals: Support default click-to-activate., a=testonly

https://hg.mozilla.org/mozilla-central/rev/8acdcd226330

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.