16509 - [blocker] code cleanup required for webshell work

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[buster]

This is an important preliminary step in cleaning up the webshell interfaces.
I'd like to remove all occurances of webshell where they are not used.  The
following diff shows these places in mailnews.  I've compiled with the changes
and it looks good.  Please check this in, or assign back to me and I will (with
you as reviewer.)  Thanks!

diff:

Index: mailnews/compose/src/nsMsgComposeService.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/compose/src/nsMsgComposeService.cpp,v
retrieving revision 1.12
diff -r1.12 nsMsgComposeService.cpp
25,26d24
< #include "nsIWebShellWindow.h"
< #include "nsIWebShell.h"
Index: mailnews/imap/src/nsImapMailFolder.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/imap/src/nsImapMailFolder.cpp,v
retrieving revision 1.181
diff -r1.181 nsImapMailFolder.cpp
40d39
< #include "nsIWebShell.h"
Index: mailnews/imap/src/nsImapProtocol.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/imap/src/nsImapProtocol.cpp,v
retrieving revision 1.167
diff -r1.167 nsImapProtocol.cpp
41d40
< #include "nsIWebShell.h"
67d65
< static NS_DEFINE_IID(kIWebShell, NS_IWEB_SHELL_IID);
Index: mailnews/local/src/nsMailboxProtocol.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/local/src/nsMailboxProtocol.cpp,v
retrieving revision 1.61
diff -r1.61 nsMailboxProtocol.cpp
44d43
< static NS_DEFINE_IID(kIWebShell, NS_IWEB_SHELL_IID);
Index: mailnews/news/src/nsNNTPProtocol.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/news/src/nsNNTPProtocol.cpp,v
retrieving revision 1.111
diff -r1.111 nsNNTPProtocol.cpp
34,37d33
< // mscott: this is a short term hack for the demo...we should be able to
remove this webshell
< // dependency at a later date....
< #include "nsIWebShell.h"
<
138d133
< static NS_DEFINE_IID(kIWebShell, NS_IWEB_SHELL_IID);

Comment 1

[Phil Peterson]

Most of these look like mscott issues, so over to him.

Comment 2

[Scott MacGregor]

Steve, these changes look fine. If you already have them in your tree
then go ahead and check them in. Thanks for cleaning that up.

Comment 3

[rubydoo123]

Steve -- setting this to M12, if you are checking these in before 11/3 then you
can change milestone to M11

Comment 4

[buster]

fixed.  this was a code level fix.

Comment 5

[laurel]

Marking verified, trusting this all was indeed checked in.