[wpt-sync] Sync PR 24474 - Refactoring hold_time_ to be hold_phase_and_time
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox82 fixed)
Tracking | Status | |
---|---|---|
firefox82 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 24474 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/24474
Details from upstream follow.
Jordan Taylor <jortaylo@microsoft.com> wrote:
Refactoring hold_time_ to be hold_phase_and_time
Changed PhaseAndTime to use a template for the type of time it will
hold.Replaced hold_time_ with hold_phase_and_time_ which will allow us to
update both hold_time and hold_phase whenever either needs to change.
Hold phase is needed so that effects can correctly calculate their own
phase.Bug: 1046833
Change-Id: I4bf1e42eaab684c18829a79acc1ab8911ec893af
Reviewed-on: https://chromium-review.googlesource.com/2135336
WPT-Export-Revision: 44d702bb512a6b0051f0aa188d4ed38701ceb091
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 29 subtests
Status Summary
Firefox
OK : 1
FAIL: 29
Chrome
OK : 1
PASS: 28
FAIL: 1
Safari
OK : 1
FAIL: 29
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/scroll-animations/scroll-animation-effect-phases.tentative.html: OK [GitHub
], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
] (Chrome: OK, Safari: OK)
Current times and effect phase before timeline start when delay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after timeline end when delay = 100 |: FAIL (Chrome: PASS, Safari: FAIL)
Verify that (play -> pause -> play) doesn't change phase/progress.: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at effect end when delay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Pause in before phase, scroll timeline into active phase, animation should remain in the before phase: FAIL (Chrome: FAIL, Safari: FAIL)
Current times and effect phase before effect delay when delay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline end when delay = 100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at effect start when delay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before effect delay when delay = 100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before timeline start when delay = 100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = 100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at effect start when delay = 100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before timeline start when delay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after timeline end when delay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at effect end when delay = 100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase before timeline start when delay = 0 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after effect end when delay = 100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline start when delay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Make scroller inactive, then set current time to an in range time: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase in timeline range when delay = 100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline end when delay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after timeline end when delay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase at timeline end when delay = 500 |: FAIL (Chrome: PASS, Safari: FAIL)
Current times and effect phase after effect end when delay = -100 |: FAIL (Chrome: PASS, Safari: FAIL)
Tests Disabled in Gecko Infrastructure
/scroll-animations/scroll-animation-effect-phases.tentative.html: OK [GitHub
], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
] (Chrome: OK, Safari: OK)
Comment 4•4 years ago
|
||
bugherder |
Description
•