1650941 - [Doorhanger V2] update doorhanger edit telemetry to account for autocomplete

Status: VERIFIED FIXED

(Toolkit :: Password Manager, task, P2)

Description

[:severin Rudie]

Update PM doorhanger edit telemetry to account for the input autocomplete. This is in support of our OKR of improving our recommended values.

Requirements

• Selecting a value from an autocomplete popup should set the didEdit* boolean state (see bug 1650929) to false
• No ID (or other information that could be correlated to a user) should be sent

Technical notes:

• autocomplete-did-enter-text will be helpful here

TODO request data review

Comment 1

[:severin Rudie]

Attachment: Bug 1650941 - expand pmgr doorhanger telemetry to include autocomplete suggestions;r=MattN

Comment 2

[:severin Rudie]

Attachment: Data review request

Comment 3

[Tim Smith 👨‍🔬 [:tdsmith]]

Comment on attachment 9168028 [details]
Data review request

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in the probe definition files and the Probe Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

n/a, expiring collection

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, interaction data.

5. Is the data collection request for default-on or default-off?

Default-on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does there need to be a check-in in the future to determine whether to renew the data?

:severin et al are responsible for renewing the collection as needed.

9. Does the data collection use a third-party collection tool?

No.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0773fa626008
expand pmgr doorhanger telemetry to include autocomplete suggestions;r=MattN

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_private_window.js

backout: https://hg.mozilla.org/integration/autoland/rev/86c4dd7f3c2ccd4d41ed35bf8c4b58972b144fe4

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=0773fa6260085dbea1805f96b40387db634ab89c&test_paths=toolkit%2Fcomponents%2Fpasswordmgr%2Ftest%2Fbrowser%2Fbrowser.ini&selectedTaskRun=H9WphkVlQIi8WTUl6Ia_CA.0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313371472&repo=autoland&lineNumber=46422

[task 2020-08-18T23:45:44.192Z] 23:45:44 INFO - GECKO(4000) | [Parent 4308, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp, line 4349
[task 2020-08-18T23:45:44.267Z] 23:45:44 INFO - TEST-INFO | Main app process: exit 0
[task 2020-08-18T23:45:44.267Z] 23:45:44 INFO - TEST-INFO | Confirming we saw 394 DOCSHELL created and 394 destroyed log strings.
[task 2020-08-18T23:45:44.268Z] 23:45:44 INFO - TEST-INFO | Confirming we saw 1210 DOMWINDOW created and 1210 destroyed log strings.
[task 2020-08-18T23:45:44.268Z] 23:45:44 ERROR - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_private_window.js | leaked 1 window(s) until shutdown [url = about:blank]
[task 2020-08-18T23:45:44.268Z] 23:45:44 ERROR - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_private_window.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xhtml]
[task 2020-08-18T23:45:44.269Z] 23:45:44 INFO - TEST-INFO | toolkit/components/passwordmgr/test/browser/browser_private_window.js | windows(s) leaked: [pid = 4308] [serial = 63], [pid = 4308] [serial = 62]
[task 2020-08-18T23:45:44.269Z] 23:45:44 INFO - TEST-INFO | toolkit/components/passwordmgr/test/browser/browser_private_window.js | This test created 1 hidden window(s)

Comment 6

[:severin Rudie]

Still working on this. The memory leak isn't trivial.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cc46e8968d7
expand pmgr doorhanger telemetry to include autocomplete suggestions;r=MattN

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7cc46e8968d7

Comment 9

[Timea Cernea [:tbabos]]

Verified-fixed on latest 82.0a1 (2020-08-24) (64-bit) on Windows 10 and MacOS 10.13.
When the username is selected from the suggestions list we will have the "did_edit_un": "false", "did_select_un": "true", event recorded for Update and Save doorhangers.

Severin, do we need this telemetry to be uplifted to Beta?

Comment 10

[:severin Rudie]

Comment on attachment 9166468 [details]
Bug 1650941 - expand pmgr doorhanger telemetry to include autocomplete suggestions;r=MattN

Beta/Release Uplift Approval Request

• User impact if declined: End user: none

Data team: will miss some data regarding the effectiveness of a new password manager UI feature

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Telemetry only change. Well covered by automated tests, and verified manually by multiple parties
• String changes made/needed: None

Comment 11

[Julien Cristau [:jcristau] (back March 1)]

Comment on attachment 9166468 [details]
Bug 1650941 - expand pmgr doorhanger telemetry to include autocomplete suggestions;r=MattN

approved for 81.0b3

Comment 12

[Julien Cristau [:jcristau] (back March 1)]

https://hg.mozilla.org/releases/mozilla-beta/rev/030b6c14b5ac

Comment 13

[Timea Cernea [:tbabos]]

Sorry for the late verification for this, lost track of it. Verified-fixed on latest Firefox Beta 81.0b7 (64-bit) on Windows 10 and MacOS 10.13. Same results as mentioned in Comment 9.