16510 - [blocker] unused webshell referneces need to be removed

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[buster]

This is an important preliminary step in cleaning up the webshell interfaces.
I'd like to remove all occurances of webshell where they are not used.  The
following diff shows these places in xpfe. I've compiled with the changes and it
looks good.  Please check this in, or assign back to me and I will check it
in (with you as reviewer.)  Thanks!

diff:

RCS file: /cvsroot/mozilla/xpfe/AppCores/src/nsAppCoresManager.cpp,v
retrieving revision 1.10
diff -r1.10 nsAppCoresManager.cpp
65d64
< #include "nsIWebShell.h"
Index: xpfe/appshell/src/nsDefaultHelper.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpfe/appshell/src/nsDefaultHelper.cpp,v
retrieving revision 1.8
diff -r1.8 nsDefaultHelper.cpp
22d21
< #include "nsIWebShell.h"
Index: xpfe/components/sample/src/nsSampleAppShellComponent.cpp
===================================================================
RCS file:
/cvsroot/mozilla/xpfe/components/sample/src/nsSampleAppShellComponent.cpp,v
retrieving revision 1.7
diff -r1.7 nsSampleAppShellComponent.cpp
39d38
< #include "nsIWebShellWindow.h"
44d42
< #include "nsIWebShell.h"

Comment 1

[David Hyatt]

This ain't my code. You should get another reviewer.  Assigning to danm.

Comment 2

[Dan M]

I'm not familiar with all of these files, but what I do know about them doesn't make them
seem dependent on WebShell. I've built, too (though the sample file seems a tad out of touch.)
Changes checked in.

Comment 3

[Claudius Gayle]

code-level fix, marking VERIFIED