Closed Bug 1651061 Opened 4 years ago Closed 3 months ago

Record `auto_admin` and `require_signon` macOS equivalents for pwmgr.reauthenticate telemetry

Categories

(Firefox :: about:logins, enhancement, P5)

Desktop
macOS
enhancement

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox77 --- unaffected
firefox78 --- unaffected
firefox79 --- wontfix
firefox80 --- fix-optional

People

(Reporter: cmuresan, Unassigned)

References

Details

Attachments

(1 file)

[Affected versions]:

  • Firefox Nightly 80.0a1, Build ID 20200706095144
  • Firefox Beta 79.0b4, Build ID 20200703150958

[Affected Platforms]:

  • macOS 10.13.6
  • macOS 10.14.6
  • macOS 10.15.3

[Prerequisites:]

  • Have a Firefox profile with at least one saved login.
  • Have an OS password set.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and navigate to the about:logins page.
  2. Click the Menu button and select the Export Logins... option.
  3. Click the Export... button and enter the OS password.
  4. Save the file to any location.
  5. Navigate to the about:telemetry#events-tab page and observe the reauthenticate - sucess telemetry event.

[Expected result]:

  • The {"auto_admin": "false", "require_signon": "true"} value is displayed in the extra parameter.

[Actual result]:

  • The extra parameter has no value.

[Notes]:

  • The issue is also reproducible for the fail and success_no_password events.
  • The issue is not reproducible on Windows 10.
  • Attached a screenshot with the issue.

This export behaviour matches the behaviour for other OS re-auth prompts, right? I don't think these two keys were ever implemented outside of Windows so this would be expected.

Flags: needinfo?(cmuresan)

As far as I can tell, yes, the behavior is the same for the edit/copy/show re-auth prompts. The only other thing I've noticed is that the success_no_prompt re-auth also does not have the two keys on Windows. Is this expected?

I don't think these two keys were ever implemented outside of Windows so this would be expected.

Is there a plan to implement the keys on macOS, now or in the future?

Flags: needinfo?(cmuresan) → needinfo?(MattN+bmo)
Blocks: 1194529
No longer blocks: 249801

(In reply to Ciprian Muresan [:cmuresan], Ecosystem QA from comment #2)

As far as I can tell, yes, the behavior is the same for the edit/copy/show re-auth prompts. The only other thing I've noticed is that the success_no_prompt re-auth also does not have the two keys on Windows. Is this expected?

Yes, I think that's expected to avoid unnecessary CPU and I/O work.

I don't think these two keys were ever implemented outside of Windows so this would be expected.

Is there a plan to implement the keys on macOS, now or in the future?

I don't think there is a compelling reason yet. We're not even sure we will use this info yet on Windows.

Severity: S2 → N/A
Status: NEW → UNCONFIRMED
Type: defect → enhancement
Ever confirmed: false
Flags: needinfo?(MattN+bmo)
Priority: -- → P5
Summary: The `extra` parameter has no value in the `success`, `fail`, and `success_no_password` telemetry events on macOS → Record `auto_admin` and `require_signon` macOS equivalents for pwmgr.reauthenticate telemetry

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: