1651082 - Solaris configure error: AttributeError: symbols_link_arg

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

I see following during build on Solaris:

...
js/src> creating ./config.data
js/src> Creating config.status
Creating config.status
Reticulating splines...
 0:01.92 File already read. Skipping: /builds/psumbera/userland-ff-78/components/desktop/firefox/firefox-78.0.1/gfx/angle/targets/angle_common/moz.build
Traceback (most recent call last):
  File "/builds/psumbera/userland-ff-78/components/desktop/firefox/firefox-78.0.1/configure.py", line 181, in <module>
    sys.exit(main(sys.argv))
  File "/builds/psumbera/userland-ff-78/components/desktop/firefox/firefox-78.0.1/configure.py", line 57, in main
    return config_status(config)
  File "/builds/psumbera/userland-ff-78/components/desktop/firefox/firefox-78.0.1/configure.py", line 176, in config_status
    return config_status(args=[], **normalize(sanitized_config))
  File "/builds/psumbera/userland-ff-78/components/desktop/firefox/firefox-78.0.1/python/mozbuild/mozbuild/config_status.py", line 148, in config_status
    the_backend.consume(definitions)
  File "/builds/psumbera/userland-ff-78/components/desktop/firefox/firefox-78.0.1/python/mozbuild/mozbuild/backend/base.py", line 130, in consume
    if (not self.consume_object(obj) and
  File "/builds/psumbera/userland-ff-78/components/desktop/firefox/firefox-78.0.1/python/mozbuild/mozbuild/backend/recursivemake.py", line 619, in consume_object
    self._process_shared_library(obj, backend_file)
  File "/builds/psumbera/userland-ff-78/components/desktop/firefox/firefox-78.0.1/python/mozbuild/mozbuild/backend/recursivemake.py", line 1279, in _process_shared_library
    if libdef.symbols_link_arg:
AttributeError: symbols_link_arg

Following patch fixes the issue:

--- a/python/mozbuild/mozbuild/frontend/data.py Fri Jun 07 12:49:57 2019 +0200
+++ b/python/mozbuild/mozbuild/frontend/data.py Wed Sep 25 13:42:06 2019 +0200
@@ -835,6 +835,8 @@
             os_target = context.config.substs['OS_TARGET']
             if os_target == 'Darwin':
                 self.symbols_link_arg = '-Wl,-exported_symbols_list,' + self.symbols_file
+            elif os_target == 'SunOS':
+                self.symbols_link_arg = '-z gnu-version-script-compat -Wl,--version-script,' + self.symbols_file
             elif os_target == 'WINNT':
                 if context.config.substs.get('GNU_CC'):
                     self.symbols_link_arg = self.symbols_file

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Ricky Stewart]

Thanks Petr, do you want to submit that as a Phabricator patch so it can be reviewed and landed? I can do it for you if not.

Comment 3

[Petr Sumbera]

I have tried to submit it via Phabricator. But something went wrong and it's not linked to the bug...

https://phabricator.services.mozilla.com/D82530

Can you please have look what I did wrong and what can be done to fix it?

Comment 4

[Petr Sumbera]

Attachment: Bug 1651082 - Add support for Solaris linker

Comment 5

[Petr Sumbera]

I think it's fixed now. Do I need to do anything else so it's pushed to the gate?

Comment 6

[Mitchell Hentges [:mhentges] 🦀]

Looks good, now that you have an approving review you can queue the patch for landing by clicking "View Stack in Lando" on that Phabricator page, then choosing to land.

Comment 7

[Petr Sumbera]

Lando says "You have insufficient permissions to land. Level 3 Commit Access is required." How can I get scm_level_3?

Comment 8

[Mike Hommey [:glandium]]

You don't need to. You can set checkin-needed, see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 9

[Petr Sumbera]

There used to be 'checkin-needed'. But not now. There is just 'checkin-needed-tb'.

Comment 10

[Mike Hommey [:glandium]]

Not in bugzilla, in phabricator. See the link in comment 8.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aac752d19467
Add support for Solaris linker r=froydnj

Comment 12

[Narcis Beleuzu [:NarcisB]]

Backed out for lint failure

Backout link: https://hg.mozilla.org/integration/autoland/rev/01da3a7fa07cbfe1f4baeceab23d2fd8242a05b9
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309271338&repo=autoland&lineNumber=115

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b5c2d5dac96
Add support for Solaris linker r=froydnj

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8b5c2d5dac96