Closed
Bug 1651156
Opened 4 years ago
Closed 4 years ago
Allow linting with clang-format when cross-compiling to Windows
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox-esr68 unaffected, firefox-esr78 unaffected, firefox78 unaffected, firefox79 unaffected, firefox80 fixed)
RESOLVED
FIXED
mozilla80
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox-esr78 | --- | unaffected |
| firefox78 | --- | unaffected |
| firefox79 | --- | unaffected |
| firefox80 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
A tiny issue, but right now we look for BIN_SUFFIX rather than for HOST_BIN_SUFFIX: see https://searchfox.org/mozilla-central/rev/7ec7ee4a9bde171ba195ab46ed6077e4baaef34d/tools/lint/clang-format/__init__.py#81.
|
Assignee | |
Comment 1•4 years ago
|
||
This allows cross-compiling to Windows targets.
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3950b19b38f0 Use HOST_BIN_SUFFIX in clang-format lint. r=ahal
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
|
||
Comment 4•4 years ago
|
||
Set release status flags based on info from the regressing bug 1650834
status-firefox78:
--- → unaffected
status-firefox79:
--- → unaffected
status-firefox-esr68:
--- → unaffected
status-firefox-esr78:
--- → unaffected
|
|
||
Updated•4 years ago
|
Keywords: regression
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•