Back button does not respect theme colors
Categories
(Firefox :: Theme, defect, P5)
Tracking
()
People
(Reporter: petcuandrei, Unassigned)
Details
Attachments
(1 file)
574 bytes,
application/json
|
Details |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0
Steps to reproduce:
I created a theme with
"button_background_active": "rgb(255, 255, 0)",
"button_background_hover": "rgb(255, 0, 0)",
web-ext run path_to_manifest
Actual results:
The back button is red and has yellow on hover.
Expected results:
The back button should be red on hover.
Reporter | ||
Comment 1•4 years ago
|
||
See the gif on this bug report https://github.com/mozilla/FirefoxColor/issues/933
Comment 2•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
Reporter | ||
Comment 3•4 years ago
|
||
good botbot
Updated•4 years ago
|
Comment 5•4 years ago
|
||
It seems to be designed this way for webextension themes w/ dark toolbar backgrounds but not w/ light toolbar backgrounds. This is presumably for readability.
I do find it weird though, the bit I linked could be changed with:
:root:-moz-lwtheme-brighttext,
toolbar[brighttext] {
--toolbarbutton-hover-background: var(--lwt-toolbarbutton-hover-background, hsla(0,0%,70%,.4));
--toolbarbutton-active-background: var(--lwt-toolbarbutton-active-background, hsla(0,0%,70%,.6));
}
toolbar[brighttext] {
--backbutton-background: hsla(0,0%,70%,.2);
--backbutton-hover-background: var(--toolbarbutton-hover-background);
--backbutton-active-background: var(--toolbarbutton-active-background);
}
or similar (toolbar[brighttext]
should be separate for back button, because :root:-moz-lwtheme-brighttext
is rather bogus in this case, a theme like "Arc Darker Theme" would be positive, even though the background behind the back button isn't dark).
Updated•4 years ago
|
Updated•4 years ago
|
Description
•