Open Bug 1651182 Opened 4 years ago Updated 4 years ago

Back button does not respect theme colors

Categories

(Firefox :: Theme, defect, P5)

80 Branch
defect

Tracking

()

People

(Reporter: petcuandrei, Unassigned)

Details

Attachments

(1 file)

Attached file manifest.json

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

I created a theme with

"button_background_active": "rgb(255, 255, 0)",
"button_background_hover": "rgb(255, 0, 0)",

web-ext run path_to_manifest

Actual results:

The back button is red and has yellow on hover.

Expected results:

The back button should be red on hover.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Theme

good botbot

Component: Theme → Themes
Product: Firefox → WebExtensions

Do you know what's happening here?

Flags: needinfo?(ntim.bugs)

https://searchfox.org/mozilla-central/rev/8d55e18875b89cdf2a22a7cba60dc40999c18356/browser/themes/shared/toolbarbuttons.inc.css#46-55

It seems to be designed this way for webextension themes w/ dark toolbar backgrounds but not w/ light toolbar backgrounds. This is presumably for readability.

I do find it weird though, the bit I linked could be changed with:

:root:-moz-lwtheme-brighttext,
toolbar[brighttext] {
  --toolbarbutton-hover-background: var(--lwt-toolbarbutton-hover-background, hsla(0,0%,70%,.4));
  --toolbarbutton-active-background: var(--lwt-toolbarbutton-active-background, hsla(0,0%,70%,.6));
}

toolbar[brighttext] {
  --backbutton-background: hsla(0,0%,70%,.2);
  --backbutton-hover-background: var(--toolbarbutton-hover-background);
  --backbutton-active-background: var(--toolbarbutton-active-background);
}

or similar (toolbar[brighttext] should be separate for back button, because :root:-moz-lwtheme-brighttext is rather bogus in this case, a theme like "Arc Darker Theme" would be positive, even though the background behind the back button isn't dark).

Flags: needinfo?(ntim.bugs)
Component: Themes → Theme
Product: WebExtensions → Firefox
Severity: -- → S4
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: