[wpt-sync] Sync PR 24503 - Finalize XRSpace.NativeFromMojo
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox80 fixed)
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 24503 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/24503
Details from upstream follow.
Alexander Cooper <alcooper@chromium.org> wrote:
Finalize XRSpace.NativeFromMojo
All XRSpaces, except for XRReferenceSpaces, implement MojoFromNative and
their NativeFromMojo method is simply a wrapper to invert the other
method. Because the StageParameters.StandingTransform method was
floor_from_mojo instead of mojo_from_floor, XRReferenceSpaces used
NativeFromMojo and MojoFromNative was the inverter.This change renames (and inverts) StageParameters standing_transform to
be mojo_from_floor. This removes the need for child classes of XRSpace
to implement NativeFromMojo. XRSpace still implements this as a
(non-virtual) helper method, because some math operations require it,
and this provides a convenience wrapper around the inversion.As noted, this does reflect an inversion for the standing transform, so
the runtimes needed to be updatedFixed:1031598
Change-Id: Ia36fe21ea2c179acb4a0d1a7096c7e5271d7a3a9
Reviewed-on: https://chromium-review.googlesource.com/2278317
WPT-Export-Revision: 5d64f359048745e5e730142031e217411f0ef58d
Assignee | ||
Comment 1•4 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=78922f243f77442742ff4bf77b800211c247c0e8
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/374c2514d032 [wpt PR 24503] - Finalize XRSpace.NativeFromMojo, a=testonly
Assignee | ||
Comment 3•4 years ago
|
||
Test result changes from PR not available.
Comment 4•4 years ago
|
||
bugherder |
Description
•