Closed Bug 1651238 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24505 - [NativeFS] Add some assertions for the locked state of streams.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox80 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24505 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24505
Details from upstream follow.

Marijn Kruisselbrink <mek@chromium.org> wrote:

[NativeFS] Add some assertions for the locked state of streams.

https://github.com/WICG/native-file-system/issues/194 suggests there
might be something weird going here, so add assertions to the tests to
make sure locked has the value we expect it to have.

Change-Id: Ia13251aeeb16734047a2f5abe7e61d7fd4bbeb0b
Reviewed-on: https://chromium-review.googlesource.com/2285293
WPT-Export-Revision: ac2bdfae7b312378494e655ddef3cff419d2afa1

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 108 tests and 5 subtests

Status Summary

Firefox

OK : 4[GitHub] 43[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] 45[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
PASS : 152[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] 155[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL : 28[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 29[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] 76[GitHub]
TIMEOUT: 3
ERROR : 9[Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 10[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview]
NOTRUN : 1

Chrome

OK : 4
PASS : 76

Safari

OK : 4
FAIL : 76

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/infrastructure/testdriver/actions/multiTouchPoints.html: ERROR
/infrastructure/testdriver/actions/multiTouchPointsReleaseFirstPoint.html: ERROR
/infrastructure/testdriver/actions/elementTiming.html
TestDriver actions: element timing: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
/infrastructure/testdriver/set_permission.https.html
Grant Permission for one realm: FAIL
Deny Permission, omit one realm: FAIL
/infrastructure/reftest/reftest_match_and_mismatch-5.html: FAIL
/infrastructure/expected-fail/uncaught-exception.html: ERROR
/infrastructure/reftest/reftest_match_and_mismatch-4.html: FAIL
/infrastructure/reftest/legacy/reftest_and_fail_0-ref.html: FAIL
/infrastructure/expected-fail/uncaught-exception-following-subtest.html: ERROR
/infrastructure/expected-fail/timeout.html: TIMEOUT
Test that should time out: NOTRUN
/infrastructure/expected-fail/unhandled-rejection-following-subtest.html: ERROR
/native-file-system/sandboxed_FileSystemWritableFileStream-write.https.any.worker.html
write() called with a blob and a valid offset: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: only one close() operation may succeed: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: close() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
write() with a valid typed array buffer: FAIL (Chrome: PASS, Safari: FAIL)
write() with a valid utf-8 string: FAIL (Chrome: PASS, Safari: FAIL)
write() with an empty blob to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: writable file streams make atomic changes on close: FAIL (Chrome: PASS, Safari: FAIL)
write() with an empty array buffer to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
write() a blob to an empty file with zero offset: FAIL (Chrome: PASS, Safari: FAIL)
write() called consecutively appends: FAIL (Chrome: PASS, Safari: FAIL)
WriteParams: write missing data param: FAIL (Chrome: PASS, Safari: FAIL)
write() with WriteParams without position to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: close() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
WriteParams: truncate missing size param: FAIL (Chrome: PASS, Safari: FAIL)
write() a blob to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
write() called with a string and a valid offset: FAIL (Chrome: PASS, Safari: FAIL)
write() called with an invalid offset: FAIL (Chrome: PASS, Safari: FAIL)
write() WriteParams without position and string appends: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: truncate() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
getWriter() can be used: FAIL (Chrome: PASS, Safari: FAIL)
write() a string to an empty file with zero offset: FAIL (Chrome: PASS, Safari: FAIL)
write() with an empty string to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
write() with a string with windows line ending preserved: FAIL (Chrome: PASS, Safari: FAIL)
WriteParams: seek missing position param: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: write() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
write() with a string with unix line ending preserved: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: writable file stream persists file on close, even if file is removed: FAIL (Chrome: PASS, Safari: FAIL)
write() WriteParams without position and blob appends: FAIL (Chrome: PASS, Safari: FAIL)
/infrastructure/expected-fail/unhandled-rejection.html: ERROR
/infrastructure/reftest/reftest_match_and_mismatch-0.html: FAIL
/infrastructure/reftest/reftest_ref_timeout.html: TIMEOUT
/infrastructure/testdriver/virtual_authenticator.html
Can remove a credential: FAIL
Can set user verified: FAIL
Can add a credential: FAIL
Can remove a virtual authenticator: FAIL
Can get the credentials: FAIL
Can create an authenticator: FAIL
Can remove all credentials: FAIL
/infrastructure/reftest/legacy/reftest_fuzzy_chain_ini.html: FAIL
/infrastructure/reftest/reftest_timeout.html: TIMEOUT
/infrastructure/testdriver/actions/multiTouchPointsReleaseSecondPoint.html: ERROR
/infrastructure/expected-fail/unhandled-rejection-single-test.html
Unhandled rejection in single-page test: FAIL
/infrastructure/browsers/firefox/prefs.html
Ensure that setting gecko prefs works: FAIL
/infrastructure/reftest/reftest_multiple_mismatch-0.html: FAIL
/native-file-system/sandboxed_FileSystemWritableFileStream-write.https.any.html
write() called with a blob and a valid offset: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: only one close() operation may succeed: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: close() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
write() with a valid typed array buffer: FAIL (Chrome: PASS, Safari: FAIL)
write() with a valid utf-8 string: FAIL (Chrome: PASS, Safari: FAIL)
write() with an empty blob to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: writable file streams make atomic changes on close: FAIL (Chrome: PASS, Safari: FAIL)
write() with an empty array buffer to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
write() a blob to an empty file with zero offset: FAIL (Chrome: PASS, Safari: FAIL)
write() called consecutively appends: FAIL (Chrome: PASS, Safari: FAIL)
WriteParams: write missing data param: FAIL (Chrome: PASS, Safari: FAIL)
write() with WriteParams without position to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: close() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
WriteParams: truncate missing size param: FAIL (Chrome: PASS, Safari: FAIL)
write() a blob to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
write() called with a string and a valid offset: FAIL (Chrome: PASS, Safari: FAIL)
write() called with an invalid offset: FAIL (Chrome: PASS, Safari: FAIL)
write() WriteParams without position and string appends: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: truncate() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
getWriter() can be used: FAIL (Chrome: PASS, Safari: FAIL)
write() a string to an empty file with zero offset: FAIL (Chrome: PASS, Safari: FAIL)
write() with an empty string to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
write() with a string with windows line ending preserved: FAIL (Chrome: PASS, Safari: FAIL)
WriteParams: seek missing position param: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: write() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
write() with a string with unix line ending preserved: FAIL (Chrome: PASS, Safari: FAIL)
atomic writes: writable file stream persists file on close, even if file is removed: FAIL (Chrome: PASS, Safari: FAIL)
write() WriteParams without position and blob appends: FAIL (Chrome: PASS, Safari: FAIL)
/infrastructure/reftest/reftest_match_and_mismatch-1.html: FAIL
/native-file-system/sandboxed_FileSystemWritableFileStream.https.any.html
createWritable({keepExistingData: true}): atomic writable file stream initialized with source contents: FAIL (Chrome: PASS, Safari: FAIL)
write() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
cursor position: truncate size < offset: FAIL (Chrome: PASS, Safari: FAIL)
truncate() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
createWritable({keepExistingData: false}): atomic writable file stream initialized with empty file: FAIL (Chrome: PASS, Safari: FAIL)
cursor position: truncate size > offset: FAIL (Chrome: PASS, Safari: FAIL)
truncate() to shrink a file: FAIL (Chrome: PASS, Safari: FAIL)
commands are queued, stream is unlocked after each operation: FAIL (Chrome: PASS, Safari: FAIL)
createWritable() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
truncate() to grow a file: FAIL (Chrome: PASS, Safari: FAIL)
/infrastructure/reftest/legacy/reftest_cycle_fail_0-ref.html: FAIL
/native-file-system/sandboxed_FileSystemWritableFileStream.https.any.worker.html
createWritable({keepExistingData: true}): atomic writable file stream initialized with source contents: FAIL (Chrome: PASS, Safari: FAIL)
write() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
cursor position: truncate size < offset: FAIL (Chrome: PASS, Safari: FAIL)
truncate() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
createWritable({keepExistingData: false}): atomic writable file stream initialized with empty file: FAIL (Chrome: PASS, Safari: FAIL)
cursor position: truncate size > offset: FAIL (Chrome: PASS, Safari: FAIL)
truncate() to shrink a file: FAIL (Chrome: PASS, Safari: FAIL)
commands are queued, stream is unlocked after each operation: FAIL (Chrome: PASS, Safari: FAIL)
createWritable() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
truncate() to grow a file: FAIL (Chrome: PASS, Safari: FAIL)
/infrastructure/testdriver/actions/multiTouchPointsTwoTouchStarts.html: ERROR
/infrastructure/reftest/legacy/fuzzy-ref-2.html: FAIL
/infrastructure/testdriver/file_upload.sub.html: ERROR [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview], OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
/infrastructure/expected-fail/failing-test.html
Failing test: FAIL
/infrastructure/reftest/reftest_match_fail.html: FAIL
/infrastructure/testdriver/generate_test_report.html
TestDriver generate_test_report method: FAIL
/infrastructure/reftest/reftest_mismatch_fail.html: FAIL
/infrastructure/reftest/reftest_multiple_mismatch-1.html: FAIL
/infrastructure/reftest/reftest_match_and_mismatch-6.html: FAIL
/infrastructure/reftest/reftest_match_and_mismatch-7.html: FAIL
/infrastructure/expected-fail/uncaught-exception-single-test.html
Uncaught exception in single-page test: FAIL
/infrastructure/testdriver/actions/multiTouchPointsWithPause.html: ERROR

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c128d234867
[wpt PR 24505] - [NativeFS] Add some assertions for the locked state of streams., a=testonly

https://hg.mozilla.org/mozilla-central/rev/4c128d234867

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.