Closed Bug 1651286 Opened 4 years ago Closed 4 years ago

PeerConnectionImpl.cpp: PeerConnectionImpl::CreatePeerConnection() appears to dereference NULL

Categories

(Core :: WebRTC, defect, P2)

Product:
Core
Component:
WebRTC
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: izbyshev, Assigned: mjf)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1651286 - remove unused static method PeerConnectionImpl::CreatePeerConnection. r?bwc!
47 bytes, text/x-phabricator-request
Details | Review

Unless I'm mistaken, the call at https://searchfox.org/mozilla-central/rev/7ec7ee4a/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#238 always crashes because of the following:

Blocks: svace-analysis
Component: Source Code Analysis → WebRTC
Product: Firefox Build System → Core

Based on what I see in searchfox[1], that static method isn't used anywhere. I'll remove it.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=777c78bcfafcb90995f07473067e53e5ad68887f

[1] https://searchfox.org/mozilla-central/search?q=symbol:_ZN7mozilla18PeerConnectionImpl20CreatePeerConnectionEv&redirect=false

Assignee: nobody → mfroman
Severity: -- → S3
Priority: -- → P2
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f31aaa73c38
remove unused static method PeerConnectionImpl::CreatePeerConnection. r=bwc

https://hg.mozilla.org/mozilla-central/rev/1f31aaa73c38

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: