Closed
Bug 1651312
Opened 4 years ago
Closed 4 years ago
Fix data type checks in browser-chrome tests
Categories
(Remote Protocol :: Agent, defect, P1)
Remote Protocol
Agent
Tracking
(firefox80 fixed)
RESOLVED
FIXED
Firefox 80
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
Because of bug 1647187 we have a lot of broken data type checks in our remote protocol browser-chrome mochitests. Here is the list:
remote/test/browser/page/browser_navigate.js
FAIL identical - Got 4, expected 4
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/page/browser_navigate.js:testBasicNavigation:30
remote/test/browser/runtime/browser_callFunctionOn.js
FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:awaitPromiseResolve:121
FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:awaitPromiseDelayedResolve:136
FAIL The subtype is null for objects - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectId:321
FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectId:332
FAIL The subtype is null for objects - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectIdArgumentReference:348
FAIL The subtype is null for objects - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn.js:objectIdArgumentReference:377
remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js
FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js:returnAsObjectTypes:53
FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js:returnAsObjectTypes:53
remote/test/browser/runtime/browser_evaluate.js
FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:awaitPromiseResolve:38
FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:awaitPromiseDelayedResolve:69
FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:returnAsObjectTypes:234
FAIL The subtype is correct - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_evaluate.js:returnAsObjectTypes:234
remote/test/browser/runtime/browser_getProperties.js
FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetOwnSimpleProperties:37
FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetCustomProperty:168
FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetPrototypeProperties:97
FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetGetterSetterProperties:124
FAIL The subtype is null for numbers - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_getProperties.js:testGetGetterSetterProperties:159
remote/test/browser/runtime/browser_remoteObjects.js
FAIL JS Object have no subtype - Got undefined, expected null
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1327
chrome://mochitests/content/browser/remote/test/browser/runtime/browser_remoteObjects.js:testObjectRelease:34
For a correct check (at the moment) you will have to modify the following code to make use of ===
and !==
:
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P3 → P1
Assignee | ||
Comment 1•4 years ago
|
||
Thankfully these are only the tests that are broken. We don't return any broken datatype via the Remote Protocol.
Assignee | ||
Comment 2•4 years ago
|
||
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/23632f23f61d
[remote] Fix invalid data type checks in browser-chrome tests. r=remote-protocol-reviewers,maja_zf
Comment 4•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
You need to log in
before you can comment on or make changes to this bug.
Description
•