1651373 - Consider switching the `Import from a File...` icon with the `Export Logins...` one and vice-versa

Status: RESOLVED WORKSFORME

(Firefox :: about:logins, enhancement, P3)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: Screenshot 2020-07-08 at 16.01.30.png

[Notes]:

• In a lot of applications hold this convention of icons where the import icon has an arrow pointing inwards and the export icon points outwards.
• We have two import options, Import from Another Browser... and Import from a File..., these two icons should be consistent between themselves. But as it is now, one of the import icons is much more similar to the export option.
• We could probably circumvent this also by changing the Export Logins... to be as consistent as the other two options. Export Logins to a File/Folder would make more sense with the icon that is attached to it.

[Affected versions]:

• Firefox Nightly 80.0a1, Build ID 20200707213111

[Affected Platforms]:

• Window 10 x64
• macOS 10.15.4
• Ubuntu 18.04

[Prerequisites:]

• Have a Firefox profile with at least one saved login.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites and navigate to the about:logins page.
2. Click the Menu button and observe the Import from a File... and Export Logins... icons.

[Expected result]:

• The Import icon should have the arrow pointing towards the file and the Export icon should be pointing from the file.

[Actual result]:

• The Import icon has an arrow pointing from a file and the Export one is pointing to a file.

[Additional Notes]:

• Attached a screenshot with the issue.

Comment 1

[Matthew N. [:MattN]]

I had the same gut reaction as you the other day but can also see some logic in the current behaviour (other than the inconsistency between the two import options). Let's see what shorlander says.

Comment 2

[Matthew N. [:MattN]]

Enhancements get N/A severity.

Comment 3

[Andrei Petcu]

Do we need to implement this Matt?

Comment 4

[katieC]

Let's please hold on making changes to icons as new design patterns are coming in the next few months (~Release 89) Thank you!

Comment 5

[Tim Giles [:tgiles]]

NI? myself so we can determine if this is still valid due to the icon updates. The two import icons are now consistent with each other, while the export icon hasn't changed.

Comment 6

[katieC]

Part of the MR1 design refresh / Firefox 89 release for menus includes:
• removing icons
• grouping like items together
• updating strings to sentence case
• and standardizing menu labels across platforms - string update from "Options" (Win) or "Preferences" (Mac) to "Settings"

UX recommendation for this menu

Import from another browser...
Import from a file...
Export logins...
Remove all logins...
[--- separator line ---]
Settings
Help

Note that the current menu has two separator lines and we're recommending consolidating to one.

Comment 7

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • You will need to remove the appropriate menu separator from the menu-button template in aboutLogins.html
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #lockwise-desktop channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test toolkit/components/passwordmgr --headless. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 8

[Tim Giles [:tgiles]]

Hmm, actually I'm going to close this as a "works for me", since Proton ended up fixing the icon issue. I'll create a new bug for dealing with the menu separators and move my mentored comment to that new bug.