1651404 - Move nsSVGDisplayableFrame and nsISVGSVGFrame to the mozilla namespace

Status: RESOLVED FIXED

(Core :: SVG, task)

Comment 1

[Robert Longson [:longsonr]]

Before I go ahead and do all the work here's the plan

nsISVGPoint -> mozilla::dom::ISVGPoint
nsISVGSVGFrame -> mozilla::ISVGSVGFrame
nsSVGDisplayableFrame -> mozilla::ISVGDisplayableFrame

Happy with the I to indicate interface? There are plenty of nsI classes, fewer I classes but there is an IProtocol abstract class.

Comment 2

[Daniel Holbert [:dholbert]]

Yeah, I think that sounds good. I did find several other IFoo abstract classes as prior art here (on top of IProtocol which you mentioned): ISensorObserver, INativePlacesEventCallback, IHistory, IToplevelProtocol, IShmemAllocator, IDispatch, IDispatchHolder, IHandlerControlHolder.

Also, as motivation here: it's helpful to have things consistently namespaced (i.e. to have these abstract classes in the same namespace as their concrete implementations, which are all in mozilla:: / mozilla::dom namespaces now). And a hypothetical naively-namespaced mozilla::nsIFoo outcome would be undesirable -- we don't want to mix "ns" with namespaces, generally.

So: this sounds good - thanks!

Comment 3

[Robert Longson [:longsonr]]

Attachment: Bug 1651404 - Move nsSVGDisplayableFrame and nsISVGSVGFrame to the mozilla namespace

Comment 4

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b8eb9cb6da3066649ea7c33bd9c011e9968db6f

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0260efdd9e0
Move nsSVGDisplayableFrame and nsISVGSVGFrame to the mozilla namespace r=dholbert

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a0260efdd9e0