Closed Bug 1651404 Opened 4 years ago Closed 4 years ago

Move nsSVGDisplayableFrame and nsISVGSVGFrame to the mozilla namespace

Categories

(Core :: SVG, task)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: longsonr, Assigned: longsonr)

References

Details

Attachments

(1 file)

No description provided.

Before I go ahead and do all the work here's the plan

nsISVGPoint -> mozilla::dom::ISVGPoint
nsISVGSVGFrame -> mozilla::ISVGSVGFrame
nsSVGDisplayableFrame -> mozilla::ISVGDisplayableFrame

Happy with the I to indicate interface? There are plenty of nsI classes, fewer I classes but there is an IProtocol abstract class.

Flags: needinfo?(dholbert)

Yeah, I think that sounds good. I did find several other IFoo abstract classes as prior art here (on top of IProtocol which you mentioned): ISensorObserver, INativePlacesEventCallback, IHistory, IToplevelProtocol, IShmemAllocator, IDispatch, IDispatchHolder, IHandlerControlHolder.

Also, as motivation here: it's helpful to have things consistently namespaced (i.e. to have these abstract classes in the same namespace as their concrete implementations, which are all in mozilla:: / mozilla::dom namespaces now). And a hypothetical naively-namespaced mozilla::nsIFoo outcome would be undesirable -- we don't want to mix "ns" with namespaces, generally.

So: this sounds good - thanks!

Flags: needinfo?(dholbert)
Summary: Move abstract SVG classes to the mozilla namespace → Move nsSVGDisplayableFrame and nsISVGSVGFrame to the mozilla namespace
Assignee: nobody → longsonr
Status: NEW → ASSIGNED
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a0260efdd9e0
Move nsSVGDisplayableFrame and nsISVGSVGFrame to the mozilla namespace r=dholbert
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Blocks: 1259861
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: