1651420 - Adding private fields to an object is side-effectful and should be marked as such.

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Adding a private field to an object is side-effectful and should block instant-evaluation.

Assuming you have already executed this in the console:

class Base {
  constructor(o) { return o; } 
}; 

class A extends Base { 
   #x 
} 
var obj = {}; 

Then typing new A(obj) should not be evaluated, as it would mutate obj. Then subsequently, if you hit enter, it would issue an error as the object would already have the field, which is a TypeError with private Fields.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1651420 - Adding private fields to an object is side-effectful and should be marked as such r?loganfsmyth

Note: Until private fields are enabled by default, this test case will take the
early return. However, I have tested locally that it fails without the fix, and
passes with the fix.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5db8d39515b3
Adding private fields to an object is side-effectful and should be marked as such r=loganfsmyth

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5db8d39515b3