1651425 - List GPUs instead of hardcoding max 2 in gfxInfo

Status: RESOLVED INCOMPLETE

(Core :: Graphics: WebRender, task, P5)

Description

[Bert Peers [:bpeers]]

From here:

// XXX: Switch to a list of devices, rather than explicitly numbering them.

This could be an actual concern when a laptop has an internal GPU plus a discrete GPU plus an external GPU (eg. Mac).

• every platform needs to be switched over;
• about:support should ideally look the same as before;
• telemetry should ideally look the same as before;

It's probably also better to keep the list of GPUs stable, and use an "GetActiveGPU" query to list the active GPU as GPU#1 in about:support/Telemetry. The current implementation (AFAIK) will switch the reported GPUs around so GetFoo() is always the active GPU and GetFoo2() the alternate. This might not scale well, plus it's harder to detect a GPU switch? (comparing GetActiveGPU() before/after vs. comparing returned strings before/after).

Low priority since there's no immediate need for this & risk of (small but annoying) knock-ons.

Comment 1

[Bert Peers [:bpeers]]

Attachment: Bug 1651425 - Report all GPUs instead of the first 2

Work in progress:

• update IDL to take arrays, plus an active GPU mask, and a "first
  active GPU" for easier backward compatibility with reporting "the"
  active GPU first (don't want to bitscan everywhere);
• changed Windows over to the new way;
• fix up about:support to show up to 4 GPUs in the same order as before
  (the active GPU comes first)
• fix up telemetry to show all GPUs, in the order enumerated, with
  "active GPU" set true/false (TODO: use the mask)

Comment 2

[Bert Peers [:bpeers]]

Attachment: bug1651425_3_test_gpus.PNG

about:support with 2 dummy GPUs added and active gpu == #2.

Comment 3

[Bert Peers [:bpeers]]

Attachment: bug1651425_3_test_gpus_telemetry.PNG

about:telemetry with 2 dummy GPUs and active GPU == #2.

Comment 4

[Bert Peers [:bpeers]]

Attachment: D82805_about_support.png

about:support seems the same as before on actual dual-GPU Dell XPS15

Comment 5

[Bert Peers [:bpeers]]

Attachment: D82805_about_telemetry.png

about:telemetry seems the same as before on actual dual-GPU Dell XPS15

Comment 6

[Bert Peers [:bpeers]]

Windows looks halfway decent, moving on to Linux (GfxInfoX11.* and cohorts).

Comment 7

[Bert Peers [:bpeers]]

Added Linux & Mac.

Comment 8

[Marco Castelluccio [:marco]]

Is this patch still relevant?

Comment 9

[Marco Castelluccio [:marco]]

(In reply to Marco Castelluccio [:marco] from comment #8)

Is this patch still relevant?

Same question (the autonag bot is nagging me because there is a r+ed patch which didn't land and no activity in the bug for a long time, and :bpeers is not active anymore).

Comment 10

[Kelsey Gilbert [:jgilbert]]

It sounds like it is, such as in the case of a laptop with an external GPU attached. (3 GPUs)
It sounds like the patch might not have been finished, but not marked WIP. It's hard to tell. It would be great for someone to pick this up and finish it before it bitrots too much.

Comment 11

[Markus Stange [:mstange]]

Looks like there's a review comment by Gijs that still needs to be addressed.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:bhood, could you have a look please?
For more information, please visit auto_nag documentation.