1651428 - In the browser toolbox's context selector, display frame targets under their related content process target

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

Today, we display targets sorted by type, but it would be really handy in the context of the browser toolbox to display frame targets under each content process.
It would actually help understanding what are each content process.
I could swear we already had a bug for this?

In order to do that, we probably should expose the processID of all frame targets via their form:
https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/devtools/server/actors/targets/browsing-context.js#563-565
https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/devtools/client/fronts/targets/browsing-context.js#31-33

Given this additional attribute on each targetFront for processes, we can probably just tweak the UI to better sort the targets:
https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/devtools/client/webconsole/components/Input/EvaluationContextSelector.js#107-147
We might have to introduce a sorting specific to the browser toolbox?

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1651428 - Sort frame target under their related process target in the context selector.

Comment 2

[Neha Kochar [:neha]]

Alex, there's a patch here but no reviewers. Could you please finalize this to close the bug?
Also, there is no dt-xx whiteboard tag for this, do we need one for dt-m2 or dt-m3?

Comment 3

[Chris Peterson [:cpeterson]]

Honza, this DevTools Fission bug has a patch, but no reviewers. Should this bug block shipping Fission? It blocks dt-fission-execution-context meta bug 1605153, but doesn't have a dt-fission whiteboard tag.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the ping Chris, flags updated.

Comment 5

[Alexandre Poirot [:ochameau]]

The attached patch was just a demo, I would need more time, which I don't have to finish this.

Comment 6

[Neha Kochar [:neha]]

Honza said this is not part of dt-fission-m3-mvp and is not considered Fission M7 blocker.

Comment 7

[Chris Peterson [:cpeterson]]

Moving "dt-fission-m3-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1651428 - [devtools] Group context selector frame targets by their PIDs in Browser Toolbox console. r=Honza.

Depends on D145880

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/441476bb4ff8
[devtools] Group context selector frame targets by their PIDs in Browser Toolbox console. r=Honza.

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/441476bb4ff8