Open Bug 1651428 Opened 1 year ago Updated 9 months ago

In the browser toolbox's context selector, display frame targets under their related content process target

Categories

(DevTools :: Framework, enhancement, P3)

enhancement

Tracking

(Fission Milestone:Future)

Fission Milestone Future

People

(Reporter: ochameau, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: dt-fission-future)

Attachments

(1 file)

Today, we display targets sorted by type, but it would be really handy in the context of the browser toolbox to display frame targets under each content process.
It would actually help understanding what are each content process.
I could swear we already had a bug for this?

In order to do that, we probably should expose the processID of all frame targets via their form:
https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/devtools/server/actors/targets/browsing-context.js#563-565
https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/devtools/client/fronts/targets/browsing-context.js#31-33

Given this additional attribute on each targetFront for processes, we can probably just tweak the UI to better sort the targets:
https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/devtools/client/webconsole/components/Input/EvaluationContextSelector.js#107-147
We might have to introduce a sorting specific to the browser toolbox?

Fission Milestone: --- → M6c

Alex, there's a patch here but no reviewers. Could you please finalize this to close the bug?
Also, there is no dt-xx whiteboard tag for this, do we need one for dt-m2 or dt-m3?

Flags: needinfo?(poirot.alex)

Honza, this DevTools Fission bug has a patch, but no reviewers. Should this bug block shipping Fission? It blocks dt-fission-execution-context meta bug 1605153, but doesn't have a dt-fission whiteboard tag.

Fission Milestone: M6c → M7
Flags: needinfo?(odvarko)

Thanks for the ping Chris, flags updated.

Severity: -- → S3
Flags: needinfo?(odvarko)
Priority: -- → P3
Whiteboard: dt-fission-m3-mvp
Flags: needinfo?(poirot.alex)

The attached patch was just a demo, I would need more time, which I don't have to finish this.

Whiteboard: dt-fission-m3-mvp → dt-fission-m3-reserve

Honza said this is not part of dt-fission-m3-mvp and is not considered Fission M7 blocker.

Fission Milestone: M7 → ---

Moving "dt-fission-m3-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.

Fission Milestone: --- → Future
Whiteboard: dt-fission-m3-reserve → dt-fission-future
You need to log in before you can comment on or make changes to this bug.