Closed Bug 1651436 Opened 1 month ago Closed 1 month ago

Fix nsIMemoryReporterManager.vsizeMaxContiguous NS_ERROR_NOT_AVAILABLE logspam

Categories

(Testing :: Mochitest, defect)

defect

Tracking

(firefox-esr68 unaffected, firefox-esr78 fixed, firefox78 wontfix, firefox79 fixed, firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- fixed
firefox78 --- wontfix
firefox79 --- fixed
firefox80 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

No description provided.

When a privileged exception objects is thrown by a function exported via
exportFunction, it is reported to the console, and a generic unprivileged
exception is re-thrown in its place. This is a problem for test harness code
which tests for getters throwing exceptions by catching them and then setting
a flag. The re-thrown exception is hidden, but the original is still reported,
and becomes a red herring for people debugging tests.

This patch catches exceptions thrown by getters (and setters, and other proxy
hooks previously overlooked), checks if they're readable by the global the
privileged object is wrapped for, wraps them if they are not, and then
re-throws them.

Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1843bcfce110
Wrap exceptions thrown by WrapPrivileged getters. r=mccr8
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fedce9af822
Backed out changeset 1843bcfce110 for causing failures related to WrapPrivileged.jsm
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bd27b15e5de4
Wrap exceptions thrown by WrapPrivileged getters. r=mccr8
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Flags: needinfo?(kmaglione+bmo)
You need to log in before you can comment on or make changes to this bug.