1651436 - Fix nsIMemoryReporterManager.vsizeMaxContiguous NS_ERROR_NOT_AVAILABLE logspam

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1651436: Wrap exceptions thrown by WrapPrivileged getters. r=mccr8

When a privileged exception objects is thrown by a function exported via
exportFunction, it is reported to the console, and a generic unprivileged
exception is re-thrown in its place. This is a problem for test harness code
which tests for getters throwing exceptions by catching them and then setting
a flag. The re-thrown exception is hidden, but the original is still reported,
and becomes a red herring for people debugging tests.

This patch catches exceptions thrown by getters (and setters, and other proxy
hooks previously overlooked), checks if they're readable by the global the
privileged object is wrapped for, wraps them if they are not, and then
re-throws them.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1843bcfce110
Wrap exceptions thrown by WrapPrivileged getters. r=mccr8

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fedce9af822
Backed out changeset 1843bcfce110 for causing failures related to WrapPrivileged.jsm

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset 1843bcfce110 (Bug 1651436) for causing failures related to WrapPrivileged.jsm

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=154875e919922646bae9c2089d16b21ed7435065&searchStr=mochitest&fromchange=1843bcfce110d11b1d68e093660b2a34cb5849bf&selectedTaskRun=R4UIgITlRteP5qYyeI0_-w.0

Failure logs:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309040986&repo=autoland&lineNumber=1798
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309042765&repo=autoland&lineNumber=8160

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd27b15e5de4
Wrap exceptions thrown by WrapPrivileged getters. r=mccr8

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/bd27b15e5de4

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1482279

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d6505eed2340

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/793ab94efb2b