1651519 - Remove nsIDOMWindowUtils::currentInnerWindowID

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Kris Maglione [:kmag]]

It has some properties which make it footgunny, especially in the face of Fission. Callers should use WindowGlobalChild.innerWindowID instead.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1651519: Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika

It has some properties which make it footgunny, especially in the face of
Fission. Callers should use WindowGlobalChild.innerWindowId instead.

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1651519: Part 2 - Also remove nsIDOMWindowUtils::outerWindowID. r=nika

Comment 3

[Chris Peterson [:cpeterson]]

M6b because wip

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45448dca59a4
Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/52317abc5c68
Part 2 - Also remove nsIDOMWindowUtils::outerWindowID. r=nika,geckoview-reviewers,agi

Comment 5

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1651519) for wpt failures in webdriver/tests/switch_to_frame/switch.py. CLOSED TRE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310589215&repo=autoland&lineNumber=77456

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=YHqPH155TCmeodyX4Bcn3g.0&revision=52317abc5c6871adf765d91b166a562ea2b39546

Backout:
https://hg.mozilla.org/integration/autoland/rev/a4b0dd4b23b3a910bcbe24b39e620f0aa36e2929

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55e9184c5617
Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/7b973a0e7be9
Part 2 - Also remove nsIDOMWindowUtils::outerWindowID. r=nika,geckoview-reviewers,agi

Comment 7

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1651519) for WPT failures in webdriver/tests/switch_to_frame/switch.py. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310621499&repo=autoland&lineNumber=77376

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=7b973a0e7be9f8213545c3e702f759c8ab70affb

Backout:
https://hg.mozilla.org/integration/autoland/rev/ee367b95887a6c46c2bfdb1eebdd68f870f3b507

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b49057b23f9
Remove nsIDOMWindowUtils::currentInnerWindowID. r=nika,remote-protocol-reviewers,webcompat-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/3a02f85528ed
Part 2 - Also remove nsIDOMWindowUtils::outerWindowID. r=nika,geckoview-reviewers,agi

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3b49057b23f9
https://hg.mozilla.org/mozilla-central/rev/3a02f85528ed