1651556 - [wpt-sync] Sync PR 24526 - Revert "Abstract portal activation handling to avoid hack of making a fake promise."

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24526 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24526
Details from upstream follow.

Keishi Hattori <[e-mail]> wrote:

Revert "Abstract portal activation handling to avoid hack of making a fake promise."

This reverts commit fdc228c7acab87083507a1276f9d8f786966f5d6.

Reason for revert: portal-activate-default.html test timeout failure
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/55803

Original change's description:

Abstract portal activation handling to avoid hack of making a fake promise.

This is somewhat verbose, but allows us to avoid the unhandled rejection
being visible to script without having to make this hack even worse.

Instead of actually calling activate(), this mirrors the spec structure
by simply calling to underlying logic, passing a resolver where it makes
sense and not (in this case, passing a substitute object) where it
doesn't.

Bug: 1102081
Change-Id: I0eecf253928bfce39afcddccf54e9bc6f6c0d549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285340
Reviewed-by: Adithya Srinivasan \<[e-mail]>
Commit-Queue: Jeremy Roman \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#786480}

TBR=[e-mail],[e-mail]

Change-Id: I00da9eee8625ca5da3a09efb7078e22a277dbfd8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1102081

Reviewed-on: https://chromium-review.googlesource.com/2288712
WPT-Export-Revision: 8cf9a3b7205d5d320a26f9e4f5fef3ed43517aaf

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 24526 applied with additional changes from upstream: 03d89c92bba52de611854f29373ba2c062ea0729, e96eb9029a884da59f3acf268dd589bc974a316a

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=86480648808881ae4f81c2b1349d537e33191a31

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/portals/portal-activate-default.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Clicking shouldn't activate if prevented.: FAIL (Chrome: FAIL, Safari: FAIL)
Clicking should activate.: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/portals/portal-activate-default.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b5497cc9c7b
[wpt PR 24526] - Revert "Abstract portal activation handling to avoid hack of making a fake promise.", a=testonly

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3b5497cc9c7b