Closed
Bug 1651593
Opened 5 years ago
Closed 5 years ago
Unchecked return value of db::GetKnownBodyIds()
Categories
(Core :: Storage: Cache API, defect, P2)
Core
Storage: Cache API
Tracking
()
RESOLVED
FIXED
mozilla80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: izbyshev, Assigned: tt)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The return value of db::GetKnownBodyIds() is not checked at https://searchfox.org/mozilla-central/rev/85ae3b91/dom/cache/Manager.cpp#136.
This function executes SQL and thus is not infallible. Is there any reason to skip the check?
|
Reporter | |
Updated•5 years ago
|
Blocks: svace-analysis
|
Assignee | |
Comment 1•5 years ago
|
||
Thanks for catching this! I don't think there is a good reason to skip the check. I will submit a patch for that.
Assignee: nobody → ttung
Severity: -- → S4
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P2
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by ttung@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa56a323d153
Check the return value of db::GetKnownBodyIds(); r=dom-workers-and-storage-reviewers,sg
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in
before you can comment on or make changes to this bug.
Description
•