Closed Bug 1651633 Opened 4 years ago Closed 4 years ago

Perma [tier2] 1:03.12 tools/lint/test/test_black.py::test_lint_black TEST-UNEXPECTED-FAIL

Categories

(Developer Infrastructure :: Lint and Formatting, defect, P5)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
defect

Tracking

(firefox-esr68 unaffected, firefox-esr78 unaffected, firefox78 unaffected, firefox79 unaffected, firefox80 affected)

Status:
RESOLVED INCOMPLETE
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox78 --- unaffected
firefox79 --- unaffected
firefox80 --- affected

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Filed by: apavel [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=309111801&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CrR7nh8AQh-impbTSTSKeQ/runs/0/artifacts/public/logs/live_backing.log

[task 2020-07-09T10:05:11.202Z] 1:03.11 Z:\task_1594288072\build\src\tools\lint\test\test_black.py
[task 2020-07-09T10:05:11.202Z] 1:03.12 ============================= test session starts =============================
[task 2020-07-09T10:05:11.202Z] 1:03.12 platform win32 -- Python 3.6.5, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- Z:\task_1594288072\build\src\obj-x86_64-pc-mingw32_virtualenvs\src-uLp3LOug-3\Scripts\python.exe
[task 2020-07-09T10:05:11.203Z] 1:03.12 rootdir: Z:\task_1594288072\build\src, inifile: Z:\task_1594288072\build\src\config\mozunit\mozunit\pytest.ini
[task 2020-07-09T10:05:11.203Z] 1:03.12 collecting ... collected 1 item
[task 2020-07-09T10:05:11.203Z] 1:03.12
[task 2020-07-09T10:05:11.203Z] 1:03.12 tools/lint/test/test_black.py::test_lint_black TEST-UNEXPECTED-FAIL
[task 2020-07-09T10:05:11.204Z] 1:03.12
[task 2020-07-09T10:05:11.204Z] 1:03.12 ================================== FAILURES ===================================
[task 2020-07-09T10:05:11.204Z] 1:03.12 _______________________________ test_lint_black _______________________________
[task 2020-07-09T10:05:11.204Z] 1:03.12
[task 2020-07-09T10:05:11.205Z] 1:03.12 lint = <function lint.<locals>.wrapper at 0x000001E723763268>
[task 2020-07-09T10:05:11.205Z] 1:03.12 paths = <function paths.<locals>._inner at 0x000001E7256156A8>
[task 2020-07-09T10:05:11.205Z] 1:03.12
[task 2020-07-09T10:05:11.206Z] 1:03.12 def test_lint_black(lint, paths):
[task 2020-07-09T10:05:11.206Z] 1:03.12 results = lint(paths())
[task 2020-07-09T10:05:11.206Z] 1:03.12 assert len(results) == 2
[task 2020-07-09T10:05:11.206Z] 1:03.12
[task 2020-07-09T10:05:11.206Z] 1:03.12 > assert "EOF" in results[0].message
[task 2020-07-09T10:05:11.206Z] 1:03.12 E assert 'EOF' in 'Reformat python'
[task 2020-07-09T10:05:11.206Z] 1:03.12 E + where 'Reformat python' = Issue({\n "linter": "black",\n "path": "Z:/task_1594288072/build/src/tools/lint/test/files/black/bad.py",\n "message":... "lineoffset": null,\n "diff": null,\n "relpath": "Z:/task_1594288072/build/src/tools/lint/test/files/black/bad.py"\n}).message
[task 2020-07-09T10:05:11.206Z] 1:03.12
[task 2020-07-09T10:05:11.206Z] 1:03.12 tools\lint\test\test_black.py:16: AssertionError
[task 2020-07-09T10:05:11.206Z] 1:03.12 ---------------------------- Captured stderr call -----------------------------
[task 2020-07-09T10:05:11.206Z] 1:03.12 10:05:08.389 black (10140) | Black version 19.10b0
[task 2020-07-09T10:05:11.206Z] 1:03.12 10:05:08.389 black (10140) | Command: Z:\task_1594288072\build\src\obj-x86_64-pc-mingw32_virtualenvs\src-uLp3LOug-3\Scripts\black --check Z:/task_1594288072/build/src/tools/lint/test/files/black\bad.py Z:/task_1594288072/build/src/tools/lint/test/files/black\invalid.py
[task 2020-07-09T10:05:11.206Z] 1:03.12 ------------------------------ Captured log call ------------------------------
[task 2020-07-09T10:05:11.206Z] 1:03.12 black.py 116 DEBUG Black version 19.10b0
[task 2020-07-09T10:05:11.206Z] 1:03.12 black.py 122 DEBUG Command: Z:\task_1594288072\build\src\obj-x86_64-pc-mingw32_virtualenvs\src-uLp3LOug-3\Scripts\black --check Z:/task_1594288072/build/src/tools/lint/test/files/black\bad.py Z:/task_1594288072/build/src/tools/lint/test/files/black\invalid.py
[task 2020-07-09T10:05:11.206Z] 1:03.12 ========================== 1 failed in 6.19 seconds ===========================
[task 2020-07-09T10:05:11.206Z] 1:03.12 Setting retcode to 1 from Z:\task_1594288072\build\src\tools\lint\test\test_black.py
[task 2020-07-09T10:05:11.880Z] 1:03.79 Z:\task_1594288072\build\src\tools\lint\test\test_lintpref.py
[task 2020-07-09T10:05:11.880Z] 1:03.79 ============================= test session starts =============================
[task 2020-07-09T10:05:11.880Z] 1:03.79 platform win32 -- Python 3.6.5, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- Z:\task_1594288072\build\src\obj-x86_64-pc-mingw32_virtualenvs\src-uLp3LOug-3\Scripts\python.exe
[task 2020-07-09T10:05:11.881Z] 1:03.79 rootdir: Z:\task_1594288072\build\src, inifile: Z:\task_1594288072\build\src\config\mozunit\mozunit\pytest.ini
[task 2020-07-09T10:05:11.881Z] 1:03.79 collecting ... collected 1 item
[task 2020-07-09T10:05:11.881Z] 1:03.79
[task 2020-07-09T10:05:11.882Z] 1:03.79 tools/lint/test/test_lintpref.py::test_lintpref PASSED

Chris, could you take a look at this?
Thank you.

Flags: needinfo?(catlee)
Regressed by: 1555560
Has Regression Range: --- → yes
Keywords: regression

Tom implemented it

Flags: needinfo?(catlee) → needinfo?(mozilla)

Set release status flags based on info from the regressing bug 1555560

status-firefox78: --- → unaffected
status-firefox79: --- → unaffected
status-firefox80: --- → affected
status-firefox-esr68: --- → unaffected
status-firefox-esr78: --- → unaffected
Flags: needinfo?(mozilla)

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.