1651731 - Only allow files that are typically executable to have shebang lines override permission check

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Tom Prince [:tomprince]]

Most of the files that we check permissions for never have shebang lines. We should explicitly control which files the shebang exception applies to. This incidentally allows us to check for permissions on binary files like pngs.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1651731: [lint] Only allow files that are typically executable to have shebang lines override permission check; r?linter-reviewers

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1651731: [lint] Add a bunch more types of files that should never be executable; r?linter-reviewers

Comment 3

[Tom Prince [:tomprince]]

Attachment: Bug 1651731: [lint] Python and shell files without `#!` should not be executable; r?linter-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/950437cb8273
[lint] Only allow files that are typically executable to have shebang lines override permission check; r=linter-reviewers,sylvestre
https://hg.mozilla.org/integration/autoland/rev/027618c1f57b
[lint] Add a bunch more types of files that should never be executable; r=linter-reviewers,perftest-reviewers,geckoview-reviewers,preferences-reviewers,agi,sylvestre,sparky
https://hg.mozilla.org/integration/autoland/rev/e2a60cd0189c
[lint] Python and shell files without `#!` should not be executable; r=linter-reviewers,perftest-reviewers,geckoview-reviewers,agi,sylvestre,sparky

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24545 for changes under testing/web-platform/tests

Comment 6

[Rob Lemley [:rjl]]

Did you intend to update the files-changed list in taskcluster/ci/source-test/mozlint.yml as well? (None of the new file types are in the list)

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/950437cb8273
https://hg.mozilla.org/mozilla-central/rev/027618c1f57b
https://hg.mozilla.org/mozilla-central/rev/e2a60cd0189c

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot