Closed Bug 1651736 Opened 3 months ago Closed 2 months ago

Reduce includes of LayersMessageUtils.h

Categories

(Core :: Graphics: Layers, task)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: sg, Assigned: sg)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

After Bug 1651714, LayersMessageUtils.h is the most expensive header according to ClangBuildAnalyzer:

*** Expensive headers:
405601 ms: /home/simon/work/fuzzy/obj-x86_64-pc-linux-gnu-optimized/dist/include/mozilla/layers/LayersMessageUtils.h (included 270 times, avg 1502 ms), included via:
  ShadowLayerUtilsX11.o ShadowLayerUtilsX11.h  (3428 ms)
  RemoteDecoderManagerParent.o RemoteDecoderManagerParent.h PRemoteDecoderManagerParent.h PRemoteDecoderManager.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3407 ms)
  DMABufSurface.cpp LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3304 ms)
  RemoteDecoderManagerChild.o RemoteDecoderManagerChild.h PRemoteDecoderManagerChild.h PRemoteDecoderManager.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3261 ms)
  PRDD.cpp PRemoteDecoderManagerParent.h PRemoteDecoderManager.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3257 ms)
  gfxPlatform.o CompositorManagerChild.h PCompositorManagerChild.h PCompositorManager.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3253 ms)
  PVRManagerChild.cpp PVRManagerChild.h PVRManager.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3233 ms)
  X11TextureHost.o X11TextureHost.h TextureHost.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3189 ms)
  PCompositorManagerChild.cpp PCompositorManagerChild.h PCompositorManager.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3175 ms)
  ...
Component: General → Graphics: Layers

This reduces the number of includes of LayersMessageUtils.h from 270 to 199
on Linux.

Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ebda1ea2441
Reduce expensive includes for LayersMessageUtils.h. r=botond
https://hg.mozilla.org/integration/autoland/rev/a0fd519f9e44
Remove unnecessary includes from LayersMessageUtils.h. r=botond
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.