1651736 - Reduce includes of LayersMessageUtils.h

Status: RESOLVED FIXED

(Core :: Graphics: Layers, task)

Description

[Simon Giesecke [:sg] [he/him]]

After Bug 1651714, LayersMessageUtils.h is the most expensive header according to ClangBuildAnalyzer:

*** Expensive headers:
405601 ms: /home/simon/work/fuzzy/obj-x86_64-pc-linux-gnu-optimized/dist/include/mozilla/layers/LayersMessageUtils.h (included 270 times, avg 1502 ms), included via:
  ShadowLayerUtilsX11.o ShadowLayerUtilsX11.h  (3428 ms)
  RemoteDecoderManagerParent.o RemoteDecoderManagerParent.h PRemoteDecoderManagerParent.h PRemoteDecoderManager.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3407 ms)
  DMABufSurface.cpp LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3304 ms)
  RemoteDecoderManagerChild.o RemoteDecoderManagerChild.h PRemoteDecoderManagerChild.h PRemoteDecoderManager.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3261 ms)
  PRDD.cpp PRemoteDecoderManagerParent.h PRemoteDecoderManager.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3257 ms)
  gfxPlatform.o CompositorManagerChild.h PCompositorManagerChild.h PCompositorManager.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3253 ms)
  PVRManagerChild.cpp PVRManagerChild.h PVRManager.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3233 ms)
  X11TextureHost.o X11TextureHost.h TextureHost.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3189 ms)
  PCompositorManagerChild.cpp PCompositorManagerChild.h PCompositorManager.h LayersSurfaces.h ShadowLayerUtils.h ShadowLayerUtilsX11.h  (3175 ms)
  ...

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1651736 - Reduce expensive includes for LayersMessageUtils.h. r=botond

This reduces the number of includes of LayersMessageUtils.h from 270 to 199
on Linux.

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1651736 - Remove unnecessary includes from LayersMessageUtils.h. r=botond

Depends on D83098

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ebda1ea2441
Reduce expensive includes for LayersMessageUtils.h. r=botond
https://hg.mozilla.org/integration/autoland/rev/a0fd519f9e44
Remove unnecessary includes from LayersMessageUtils.h. r=botond

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5ebda1ea2441
https://hg.mozilla.org/mozilla-central/rev/a0fd519f9e44