Closed Bug 1651763 Opened 3 months ago Closed 2 months ago

[wpt-sync] Sync PR 24534 - [LayoutNG] Only spanner siblings are considered adjacent.

Categories

(Core :: Layout: Columns, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24534 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24534
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

[LayoutNG] Only spanner siblings are considered adjacent.

The spec isn't crystal clear, but unconditionally considering spanners
that are siblings of another spanner's ancestors as adjacent is
definitely wrong. We need to resume column content layout inside the
parent block of the spanner, since it may have a fixed block-size,
block-end padding / border, or anything else that we'd just lose
otherwise.

This breaks one existing (non-WPT) test, but I'm not convinced that the
test is valid. Filed crbug.com/1100849 for it.

It also fixes 3 WPT tests. They were all quite complex, so I added a
couple of simple ones, that demonstrate this fix more to the point.

Bug: 829028
Change-Id: I9d55153f859dd84a5019e7d4dd09453f7f9ee1e4
Reviewed-on: https://chromium-review.googlesource.com/2290150
WPT-Export-Revision: e3dfc70ab7ca20093be46a81074265db7af15f8b

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-multicol/non-adjacent-spanners-001.html: FAIL

New Tests That Don't Pass

/css/css-multicol/non-adjacent-spanners-001.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fcc979d47133
[wpt PR 24534] - [LayoutNG] Only spanner siblings are considered adjacent., a=testonly
https://hg.mozilla.org/integration/autoland/rev/b77633550e4e
[wpt PR 24534] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.