1651786 - [wpt-sync] Sync PR 24528 - Revert "Do not expose media devices before a successful getUserMedia()"

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24528 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24528
Details from upstream follow.

Mohsen Izadi <[e-mail]> wrote:

Revert "Do not expose media devices before a successful getUserMedia()"

This reverts commit d64e736aa8c7976b12b33f92472f7950bf0215b9.

Reason for revert: Caused chrome_all_tast_tests / camera.CCAUISanity.fake failures; e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/7680

Original change's description:

Do not expose media devices before a successful getUserMedia()

This is a spec-compliance change.

This CL also adds some improvements to the blink MediaDevices unit test.

Bug: 1101860
Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808
Commit-Queue: Guido Urdaneta \<[e-mail]>
Reviewed-by: Harald Alvestrand \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#786253}

TBR=[e-mail],[e-mail]

Change-Id: I41b676c7d3e437c06d23f2b46270453f1cc81670
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1101860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288282
Reviewed-by: Mohsen Izadi \<[e-mail]>
Commit-Queue: Mohsen Izadi \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#786615}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6abee07733f64df992c486fbdc7d176a28ee4bf

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 6 subtests

Status Summary

Firefox

OK : 3
PASS: 157
FAIL: 24

Chrome

OK : 3
PASS: 188
FAIL: 1

Safari

OK : 3
PASS: 157
FAIL: 24

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/mediacapture-streams/idlharness.https.window.html
MediaStreamTrack interface: operation getCapabilities(): FAIL
MediaStreamTrack interface: track must inherit property "getCapabilities()" with the proper type: FAIL

New Tests That Don't Pass

/audio-output/setSinkId.https.html
List device, setSinkId should be allowed on the default, the rest of the devices will get a NotAllowedError: FAIL (Chrome: FAIL, Safari: FAIL)
setSinkId fails with NotFoundError on made up deviceid: FAIL (Chrome: PASS, Safari: FAIL)
setSinkId on default audio output should always work: FAIL (Chrome: PASS, Safari: FAIL)
/mediacapture-streams/idlharness.https.window.html
Navigator interface: operation getUserMedia(MediaStreamConstraints, NavigatorUserMediaSuccessCallback, NavigatorUserMediaErrorCallback): FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: audioinput must inherit property "getCapabilities()" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: videoinput must inherit property "getCapabilities()" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface object name: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo must be primary interface of videoinput: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface object length: FAIL (Chrome: PASS, Safari: FAIL)
MediaStreamTrack interface: operation getCapabilities(): FAIL (Chrome: PASS, Safari: PASS)
MediaStreamTrack interface: track must inherit property "getCapabilities()" with the proper type: FAIL (Chrome: PASS, Safari: PASS)
Navigator interface: navigator must inherit property "getUserMedia(MediaStreamConstraints, NavigatorUserMediaSuccessCallback, NavigatorUserMediaErrorCallback)" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
Stringification of videoinput: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo must be primary interface of audioinput: FAIL (Chrome: PASS, Safari: FAIL)
InputDeviceInfo interface: operation getCapabilities(): FAIL (Chrome: PASS, Safari: FAIL)
Stringification of audioinput: FAIL (Chrome: PASS, Safari: FAIL)
Navigator interface: calling getUserMedia(MediaStreamConstraints, NavigatorUserMediaSuccessCallback, NavigatorUserMediaErrorCallback) on navigator with too few arguments must throw TypeError: FAIL (Chrome: PASS, Safari: FAIL)
/mediacapture-streams/MediaDevices-getUserMedia.https.html
getUserMedia() fails with exact invalid resizeMode.: FAIL (Chrome: PASS, Safari: FAIL)
getUserMedia() supports setting none as resizeMode.: FAIL (Chrome: PASS, Safari: FAIL)
getUserMedia() supports setting crop-and-scale as resizeMode.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ea0d4cd3ff0
[wpt PR 24528] - Revert "Do not expose media devices before a successful getUserMedia()", a=testonly

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6ea0d4cd3ff0