Closed Bug 1651805 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 24539 - [LayoutNG] Spanner break token and fragmentation improvements.

Categories

(Core :: Layout: Columns, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24539 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24539
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

[LayoutNG] Spanner break token and fragmentation improvements.

We were creating incorrect outgoing break tokens from column content
that was interrupted by two or more adjacent spanners. The outgoing
break token would point to the second spanner, rather than any column
content that would follow. To fix this, make sure that we don't
interrupt column layout until we have looked past all adjacent spanners,
to find the right place to resume column layout right away.

This gets especially more fun if we're nested inside another
fragmentation context, because then we may not be able to resume column
content layout in the same outer fragmentation. Therefore we need to
keep proper track of all the spanner break tokens.

Introduce a walker to streamline processing of the multicol parts
(spanners and/or column content), and thus make LayoutChildren() easier
to follow. We're now also better at handling parallel flows established
inside spanners.

Bug: 1066617, 829028
Change-Id: I7ad3f8f19f7258e2f8a588034c0002249efdaf20
Reviewed-on: https://chromium-review.googlesource.com/2288705
WPT-Export-Revision: cb31dbd3a1c01283e7fba5eb0c5cde072ad02c63

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests

Status Summary

Firefox

PASS: 8

Chrome

PASS: 7
FAIL: 1

Safari

PASS: 8

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4f79afc7b4f6
[wpt PR 24539] - [LayoutNG] Spanner break token and fragmentation improvements., a=testonly
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.