1651808 - OpenPGP only manageable for default mail "identity"

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect, P1)

Description

[Arvidt]

Attachment: Bildschirmfoto_2020-07-09_22-34-01.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

TB 78 Beta 4 on Debian 64 Bit (upgraded from TB 68.9 from Debian Distro)

I have a mail main account and several "identities" associated with it (mail aliases at the mail provider side).

I imported two pre-existing private keys from gnupg into TB78. One for the mail account default identity, and the other key for one of an additional non-default identity.

TB detected the key for the account default identity and I could set it up to use for OpenPGP (assign key), see screenshot.

The I click on Account settings -> Manage Identities -> <select the non-default identity> -> Edit -> End-to-End Encryption

Actual results:

I see "OpenPGP None", no key associated ( see screenshot).

Expected results:

There should be shown the matching key for the non-default identity mail-address, and OpenPGP should be enabled.

Now I tested some things if I could get a workaround. I klicked "Add Key" in the "edit non-default identity" and "Generate key" (since "import" does not work).
Than for temporarily, the key is shown with the non-default identity. But when clicking forth and back to the main account etc. then the new generated key is again not assiciated with the non-default identity anymore.

Then I figured out that I can enable OpenPGP with the matching key only for an identity if the identity is set as default.

If I then edit the previous default and now non-default identity then there is the key association also lost and "OpenPGP None" is shown.

But when I set it as default again, the key association is there again.

So it looks like key/encryption management for non-defaul identities does not work. I am surprised this is the case for Beta 4 since having several identities is a basic use case I think?

Comment 1

[Arvidt]

Attachment: Edit non-default identity

key is not seen, OpenPGP disabled

Comment 2

[Arvidt]

Even when You navigate to account settings -> manage identities -> <select the bold written default identity> -> Edit -> End-to-end Encryption: "OpenPGP: None" (see second screenshot)

While in the main account setting -> End-to-end Encryption OpenPGP is enabled for the default identity (see first screenshot)

Comment 3

[Kai Engert (:KaiE:)]

With my latest local build, I see an exception that Preferences is undefined.
I have a patch for that, and that seems to help, the key for the secondary identity is shown.

However, I still get an exception in am-e2e.js from the following code, which says ".on is not a function".

  Preferences.get(`mail.identity.${gIdentity.key}.openpgp_key_id`).on(
    "change",
    updateOpenPgpSettings
  );

Comment 4

[Kai Engert (:KaiE:)]

Attachment: 1651808-v1.patch

Comment 5

[Alessandro Castellani [:aleca]]

Attachment: 1651808-openpgp-identities.diff

We were missing the preferenceBindings.js from the dialog.

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9163568 [details] [diff] [review]
1651808-openpgp-identities.diff

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: Unable to manage OpenPGP personal key from the edit identity subdialog.
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): Low as the patch only adds a missing javascript file from the dialog.

Comment 7

[Kai Engert (:KaiE:)]

Comment on attachment 9163568 [details] [diff] [review]
1651808-openpgp-identities.diff

let's keep beta in sync, too

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ff06f1dd05d5
Fix OpenPGP key identity manager for non-default identities. r=KaiE

Comment 9

[Arvidt]

Confirm: Works for me now with Build 20200716204135

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9163568 [details] [diff] [review]
1651808-openpgp-identities.diff

Approved for beta
Approved for esr78

Comment 11

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-esr78/rev/acca49623cf3975f7d81de828ce03927955124ef
https://hg.mozilla.org/releases/comm-beta/rev/4149017a9445875096943d7cef057ccb23be475c