1652025 - Remove Intervention for "Download prompt for files with no content-type"

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, task, P3)

Description

[Oana Arbuzov [:oanaarbuzov]]

The download prompt is no longer triggered when accessing the site on a clean profile.

Environment:
Browser / Version: Firefox Nightly 80.0a1 (2020-07-09)
Operating System: Windows 10 Pro

Taking in consideration the above, the Intervention can be removed.

Comment 1

[Karl Dubost💡 :karlcow]

Attachment: GitHub Pull Request

Comment 2

[Ksenia Berezina [:ksenia]]

While this intervention was originally made for slideshare in 1577870 , it is used on two other websites:

      urls: [
        "https://ads-us.rd.linksynergy.com/as.php*",
        "https://www.office.com/logout?sid*",
      ],

we removed the slideshare domain in https://bugzilla.mozilla.org/show_bug.cgi?id=1623621 , but didn't update the bug id, so this is still pointing to 1577870, which is confusing.

So we actually need to test these two bugs instead of slideshare:

yahoo mail https://bugzilla.mozilla.org/show_bug.cgi?id=1583366 (I was never been able to reproduce the issue with yahoo myself, but we got multiple reports about the problem, so this is tricky. Maybe we just keep it?)

office 365 https://bugzilla.mozilla.org/show_bug.cgi?id=1584591 (needs office 365 account)

Comment 3

[Mike Taylor [:miketaylr]]

Oana, can you re-test the 2 sites according to Comment #2, please? Not urgent, we'll move this to the next release.

Comment 4

[Ciprian Ciocan [:ciprian]]

Mike, I accessed the URL's from the comment having the intervention disabled and:

• on https://ads-us.rd.linksynergy.com/as.php - a prompt is displayed after I access the link
• on https://www.office.com/logout?sid* - I receive a blank page.

Tested with:
Browser / Version: Firefox Nightly 80.0a1 (2020-07-23)
Operating System: macOS 10.15.6

Comment 5

[Ksenia Berezina [:ksenia]]

Cipri, just to make sure that we can remove the office365 intervention, could you please check if the download box doesn't appear by following the steps that are described in this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1580607#c12. I've tried using office365 credentials we have to test this, but there is two factor authentication :(

Comment 6

[Ciprian Ciocan [:ciprian]]

Ksenia, I tested the issue taking the steps described in the comment having the intervention disabled, and I did not get the download prompt when I logged out from the account.

Tested with:
Browser / Version: Firefox Nightly 81.0a1 (2020-08-04)
Operating System: macOS 10.15.6

Comment 7

[Ksenia Berezina [:ksenia]]

Thanks Cipri. I've removed the office intervention. Will keep the yahoo intervention for now

Comment 8

[Ksenia Berezina [:ksenia]]

Changes were shipped in https://bugzilla.mozilla.org/show_bug.cgi?id=1649243