Closed Bug 1652079 Opened 3 months ago Closed 2 months ago

mutationBreakpoint type is incorrectly written with an "s" in the IMMEDIATE_MUTATIONS array

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox80 fixed)

RESOLVED FIXED
Firefox 80
Tracking Status
firefox80 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

Details

Attachments

(1 file)

When implementing mutation breakpoints as new custom mutations to the inspector, a small mistake was made:

This means that mutationBreakpoints are currently queued and accumulated before they are sent to the client. In general adding new custom mutations should be avoided, and if the intent was to add them to IMMEDIATE_MUTATIONS, an event might be a better fit.

In this particular case, we need to decide if we simply remove the erroneous "mutationBreakpoints" from IMMEDIATE_MUTATIONS, or if we correct it. If we decide to correct it, we might as well switch to an event? The ultimate decision should depend on how frequent these events/mutations can be.

Hi Logan!

According to the comment in IMMEDIATE_MUTATIONS, it seems that we care about avoiding the queue for mutation breakpoint updates:

  // These should be delivered right away in order to be sure that the
  // fronts have not been removed due to other non-throttled mutations.
  "mutationBreakpoints",

But in practice, the feature has been working without being "immediate" (see summary above). Do you think we should remove the entry from the array, or should we fix it? And if we fix it, what about using a regular event instead of a mutation?

Flags: needinfo?(loganfsmyth)

Hmmm, I guess we're okay to remove and we can see what happens.

Flags: needinfo?(loganfsmyth)
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b97c31c96524
Remove mutationBreakpoints from WalkerActor IMMEDIATE_MUTATIONS list r=loganfsmyth
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
You need to log in before you can comment on or make changes to this bug.