1652171 - ThreadSanitizer: data race [@ mozilla::dom::Element_Binding::removeAttribute] vs [@ AttrArray::GetAttr]

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Byron Campen [:bwc]]

Attachment: tsan output

Comment 1

[Emilio Cobos Álvarez (:emilio)]

This looks also wrong. Main thread (the thread doing the write) is paused when that read (from the style thread) happens.

It is paused via this rust code, which may be what is confusing TSAN?

All the reports regarding the style system I've looked at so far seem false positives... It seems there's something very broken about the TSAN setup with Rust code :/

Comment 2

[Simon Giesecke [:sg] [he/him]]

FWIW, there are also crashes related to AttrArray::GetAttr: https://crash-stats.mozilla.org/signature/?signature=AttrArray%3A%3AGetAttr&date=%3E%3D2020-07-06T15%3A30%3A00.000Z&date=%3C2020-07-13T15%3A30%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#reports and https://crash-stats.mozilla.org/signature/?signature=mozilla%3A%3Adetail%3A%3AnsTStringRepr%3CT%3E%3A%3AEquals%20%7C%20AttrArray%3A%3AGetAttr&date=%3E%3D2020-07-06T15%3A30%3A00.000Z&date=%3C2020-07-13T15%3A30%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#reports. There's no bug on file for those signatures yet, but I wasn't sure if it makes sense to add them here either.

Comment 3

[Christian Holler (:decoder)]

Likely invalid, because the build used for this missed rust code instrumentation.