Closed Bug 1652181 Opened 2 months ago Closed 2 months ago

Only call UpdateBias when the frame changes.

Categories

(Core :: Graphics: WebRender, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox79 --- fixed
firefox80 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(1 file)

Previously we were calling it at 60fps for 30fps video. This meant that any bias would be cancelled out on the vsyncs where we didn't present anything. This also makes us match the non-WebRender path which only calls UpdateBias after a frame has actually been drawn.

Previously we were calling it at 60fps for 30fps video. This meant that
any bias would be cancelled out on the vsyncs where we didn't present
anything. This also makes us match the non-WebRender path which only
calls UpdateBias after a frame has actually been drawn.

Assignee: nobody → jmuizelaar
Status: NEW → ASSIGNED
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d425dd5dee95
Only call UpdateBias when the frame changes. r=sotaro
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80

Comment on attachment 9162960 [details]
Bug 1652181 - Only call UpdateBias when the frame changes.

Beta/Release Uplift Approval Request

  • User impact if declined: Sections of noticeable stuttering when playing video with WebRender at a rate different than the refresh rate (e.g. 30fps video on a 60fps monitor)

From https://bugzilla.mozilla.org/show_bug.cgi?id=1614083#c92 "I would consider this now being a drastic improvement compared to before the state of bug #1652181"

  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): This changes our video sync behaviour which is hard to test.

It only affects WebRender users so that lowers risk and it also makes the behaviour of more similar to the non-WebRender path which is very well tested.

It's a very small patch so it's easy to revert late in the cycle.

  • String changes made/needed:
Attachment #9162960 - Flags: approval-mozilla-beta?

Comment on attachment 9162960 [details]
Bug 1652181 - Only call UpdateBias when the frame changes.

Simple fix for a video stuttering issue with WR enabled. Approved for 79.0b8.

Attachment #9162960 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.