Open Bug 1652378 Opened 4 years ago Updated 2 years ago

Make sure Rust code isn’t compiled unnecessarily when C++ code changes

Categories

(Firefox Build System :: General, task, P5)

task

Tracking

(Not tracked)

People

(Reporter: n.nethercote, Unassigned)

References

(Blocks 1 open bug)

Details

Lina said: "right now, even something pretty small, like adding or changing an XPIDL method to a Sync or Places interface, ends up rebuilding all our Rust crates, including Stylo and WebRender."

(In reply to Nicholas Nethercote [:njn] from comment #0)

Lina said: "right now, even something pretty small, like adding or changing an XPIDL method to a Sync or Places interface, ends up rebuilding all our Rust crates, including Stylo and WebRender."

Isn't this kind of a function of our header/library layering story being terrible?

If I touch a idl file in services/interfaces, the build touches xptdata.h, which is listed here:
1:34.62 [style 0.0.1] cargo:rerun-if-changed=/tmp/gecko/obj-x86_64-pc-linux-gnu/dist/include/xptdata.h
That's also the only crate that I get rebuilt (well, also geckoservo and gkrust, but that's because of style).

Lina, what specific file(s) are you touching when webrender rebuilds?

Flags: needinfo?(lina)
Severity: -- → S4
Priority: -- → P5

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.

Flags: needinfo?(lina)
You need to log in before you can comment on or make changes to this bug.