1652416 - Remove XPCOM methods from calUtils

Status: RESOLVED FIXED

(Calendar :: Internal Components, task)

Description

[Geoff Lankow (:darktrojan)]

With a bit of rearranging the generateQI, generateClassQI, and generateCI methods of calUtils are unnecessary. I'm going to remove them to get closer to the "right" way of doing things, so that it's less likely to break in the future.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1652416-generateclassqi-1.diff

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1652416-generateci-generateqi-1.diff

You mentioned about this being a potential memory leak, but I can't see how that would happen, unless the first instance of each class encountered was stored in a lookup table or something like that. Which would be weird.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 9163154 [details] [diff] [review]
1652416-generateci-generateqi-1.diff

Review of attachment 9163154 [details] [diff] [review]:
-----------------------------------------------------------------

This is guidance I got many many years ago when I got started. I didn't question it, but I think it had something to do with how xpconnect/xpcom works. I think we could give this a try though, I'm hoping we'd get rid of xpcom anyway.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3e574966802f
Remove cal.generateClassQI and uses of cal.generateQI where no classInfo is present. r=Fallen
https://hg.mozilla.org/comm-central/rev/187bf4f96b30
Move nsIClassInfo implementations and remove cal.generateCI and cal.generateQI. r=Fallen

Comment 6

[Geoff Lankow (:darktrojan)]

This does cause memory leaks. A lot in some places that aren't really related to calendar, like the webextensions tests. I'm not in a good place to investigate this now, so I backed part of it out.

https://hg.mozilla.org/comm-central/rev/dbbabbfeef8efb62967f43f4a59cbcaffb475771

Comment 7

[Geoff Lankow (:darktrojan)]

I think we can just forget about the backed out part until we deCOMtaminate calendar completely. Resetting the status to fixed because we did actually fix something.