1652460 - Tab sound indicator doesn't display after switch stream of twitch.tv

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Alice0775 White]

Steps To Reproduce:

1. Open https://www.twitch.tv/ (not need log-in).
2. Click a stream in RECOMMENDED　CHANNELS pane.
   And unmute if any.
   --- Tab sound indicator should appear as expected.
3. Click another stream in RECOMMENDED　CHANNELS pane.
   --- Tab sound indicator will disappear.

Actual Results:
Tab sound indicator will disappear though the sound is still there.

Expected Results:
Tab sound indicator should appear

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1b52ba682823b0f5ee962f467018cf08b38d05e0&tochange=3feca854d60fbd2462e0f2804202376286ce4a92

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1652460 - part1 : always store the audible state change.

Whenever the audible state changes, we should always store the latest state but only notify the change after playing starts.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1652460 - part2 : add a test.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8617d54c6f54
part1 : always store the audible state change. r=bryce
https://hg.mozilla.org/integration/autoland/rev/2764df1f9193
part2 : add a test. r=bryce

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8617d54c6f54
https://hg.mozilla.org/mozilla-central/rev/2764df1f9193

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 9163581 [details]
Bug 1652460 - part1 : always store the audible state change.

Beta/Release Uplift Approval Request

• User impact if declined: The sound indicator sometime would not work correctly on Twitch.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Follow comment0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This minor change is about always updating internal audible state, which doesn't introduce any new check or big behavior change. In addition, we also have an automation test for that.
• String changes made/needed:

Comment 6

[Hani Yacoub, Desktop QA]

Verified on Firefox 80.0a1 (2020-07-15) on Windows 10 x64, MacOS 10.14 and on Ubuntu 18.04.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9163581 [details]
Bug 1652460 - part1 : always store the audible state change.

Approved for 79.0b9. Thanks for including a test.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/774e71dac50b
https://hg.mozilla.org/releases/mozilla-beta/rev/1b8ddfd11888

Comment 9

[Hani Yacoub, Desktop QA]

Verified on Firefox 79.0b9 on Windows 10 x64, MacOS 10.14 and on Ubuntu 20.04.