Closed Bug 1652513 Opened 4 years ago Closed 4 years ago

Use groups configuration to control message lifetime and frequency

Categories

(Firefox :: Messaging System, defect, P1)

defect

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: andreio, Assigned: andreio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Lets remove the provider(pref) specified message configuration, this is limiting because we want to share the same values with experiment messages of the same type. These should be configured through remote messages.

Additionally for the cfr provider we run into this bug where turning it off (don't recommend addons or features) hides it from our devtools because of this line which we don't need anymore.

Tech doc https://docs.google.com/document/d/1Q_kR5vwp1f--v67D9whPZcr8pxJtl4kIW7qqz84thaA/edit

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(tspurway)
Severity: -- → S3
Flags: needinfo?(tspurway)
Pushed by aoprea@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ed6c3abb15c2 Use Remote Settings groups configuration to control message lifetime and frequency r=k88hudson

Backed out for node failures.

backout: https://hg.mozilla.org/integration/autoland/rev/8483fa90d65993f5e294e350b93797bf494f6ce5

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-newtab-unit-tests%2Cnewtab&revision=ed6c3abb15c23f69cc2d7997f9cbe5523b2f3534&selectedTaskRun=TAp5ZaCBRy6ZpZu9SvEe6A.0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315038996&repo=autoland&lineNumber=91

[task 2020-09-07T19:30:18.299Z] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules/karma/node_modules/fsevents):
[task 2020-09-07T19:30:18.299Z] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
[task 2020-09-07T19:30:18.299Z]
[task 2020-09-07T19:30:18.303Z] added 1205 packages from 1801 contributors and audited 1283 packages in 13.707s
[task 2020-09-07T19:30:18.785Z]
[task 2020-09-07T19:30:18.785Z] 39 packages are looking for funding
[task 2020-09-07T19:30:18.785Z] run npm fund for details
[task 2020-09-07T19:30:18.785Z]
[task 2020-09-07T19:30:18.786Z] found 110 vulnerabilities (103 low, 3 moderate, 4 high)
[task 2020-09-07T19:30:18.786Z] run npm audit fix to fix them, or npm audit for details
[task 2020-09-07T19:30:18.858Z] + node bin/try-runner.js
[task 2020-09-07T19:30:18.913Z] TEST START | checkBundles
[task 2020-09-07T19:30:25.276Z] TEST-UNEXPECTED-FAIL checkBundles | Activity Stream bundle out of date
[task 2020-09-07T19:30:25.278Z] { checkBundles: false }
[task 2020-09-07T19:30:25.278Z] CODE 1
[taskcluster 2020-09-07 19:30:25.706Z] === Task Finished ===
[taskcluster 2020-09-07 19:30:25.707Z] Unsuccessful task run with exit code: 1 completed in 174.399 seconds

Flags: needinfo?(andrei.br92)
Pushed by aoprea@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/79894e9a9ccc Use Remote Settings groups configuration to control message lifetime and frequency r=k88hudson
Pushed by aoprea@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/27a0738dc45b Use Remote Settings groups configuration to control message lifetime and frequency r=k88hudson
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Flags: needinfo?(andrei.br92)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: