Closed Bug 1652554 Opened 4 years ago Closed 3 years ago

[meta] Fix failing DOM: Core & HTML mochitests with cross-origin and Fission enabled

Categories

(Core :: DOM: Core & HTML, defect, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Project Flags:
Fission Milestone M7

People

(Reporter: neha, Unassigned)

References

Details

(Keywords: meta)

These tests are marked as skipped/failed for cross-origin and Fission, and need to be fixed.
docshell/test/mochitest/test_bug551225.html
dom/base/test/test_bug345339.html
dom/base/test/test_bug398243.html
dom/base/test/test_bug622088.html
dom/base/test/test_bug927196.html
dom/base/test/test_gsp-qualified.html
dom/base/test/test_history_document_open.html
dom/base/test/test_pluginAudioNotification.html
dom/base/test/test_pluginMutedBeforePlay.html
dom/html/test/forms/test_input_hasBeenTypePassword_navigation.html
dom/html/test/forms/test_restore_form_elements.html
dom/html/test/forms/test_save_restore_radio_groups.html
dom/html/test/test_bug277724.html
dom/html/test/test_srcdoc-2.html
dom/tests/mochitest/bugs/test_bug593174.html
dom/tests/mochitest/dom-level1-core/test_nodesetnodevaluenomodificationallowederr.html
dom/tests/mochitest/general/test_framedhistoryframes.html

https://docs.google.com/spreadsheets/d/16G5AZhHWWow3rBgim4QBHzWXMIIJiky2SzXYgDMTTKY/edit#gid=1354562828&range=2:19

More info: https://wiki.mozilla.org/Project_Fission/Enabling_Tests_with_Fission#Cross-Origin_Mochitests

Fission Milestone: --- → M6b
Summary: Fix failing mochitests with cross-origin and Fission enabled → Fix failing DOM core mochitests with cross-origin and Fission enabled
Blocks: 1652556
Severity: -- → S3
Priority: -- → P3

(In reply to Neha Kochar [:neha] from comment #0)

These tests are marked as skipped/failed for cross-origin and Fission, and need to be fixed.
docshell/test/mochitest/test_bug551225.html
dom/base/test/test_bug345339.html
dom/base/test/test_bug398243.html
dom/base/test/test_bug622088.html
dom/base/test/test_bug927196.html
dom/base/test/test_gsp-qualified.html
dom/base/test/test_history_document_open.html
dom/base/test/test_pluginAudioNotification.html

Hi Alastor, are you the right person to investigate this
test_pluginAudioNotification.html ?

dom/base/test/test_pluginMutedBeforePlay.html

Hi Alastor, are you the right person to investigate this
test_pluginMutedBeforePlay.html?

dom/html/test/forms/test_input_hasBeenTypePassword_navigation.html

Hi Matt, are you the right person to investigate this test_input_hasBeenTypePassword_navigation.html?

dom/html/test/forms/test_restore_form_elements.html
dom/html/test/forms/test_save_restore_radio_groups.html
dom/html/test/test_bug277724.html
dom/html/test/test_srcdoc-2.html
dom/tests/mochitest/bugs/test_bug593174.html
dom/tests/mochitest/dom-level1-core/test_nodesetnodevaluenomodificationallowederr.html
dom/tests/mochitest/general/test_framedhistoryframes.html

Hey Olli, can you start to look into some of these?
Also, several looks session history related. Are they known issues that need to wait for other Fission SH work?
Thanks!

https://docs.google.com/spreadsheets/d/16G5AZhHWWow3rBgim4QBHzWXMIIJiky2SzXYgDMTTKY/edit#gid=1354562828&range=2:19

More info: https://wiki.mozilla.org/Project_Fission/Enabling_Tests_with_Fission#Cross-Origin_Mochitests

Flags: needinfo?(bugs)
Flags: needinfo?(alwu)
Flags: needinfo?(MattN+bmo)

Do you maybe have the wrong Matt? I don't recall being involved in most of those tests.

(In reply to Matthew N. [:MattN] from comment #2)

Do you maybe have the wrong Matt? I don't recall being involved in most of those tests.

Hey Matt, sorry I wasn't clear enough. I was asking for this particular test test_input_hasBeenTypePassword_navigation.html which was created by you.

We're close to end supporting Flash, so those tests are no longer needed.

Flags: needinfo?(alwu)

(In reply to Alastor Wu [:alwu] from comment #4)

We're close to end supporting Flash, so those tests are no longer needed.

Thanks Alastor. Does that mean we can remove the tests now so that they don't block M6b? If so, can you help with this?

Flags: needinfo?(alwu)
Depends on: 1656025

Filed bug1656025 to remove those tests.

Flags: needinfo?(alwu)

(comment obsolete, I've updated the spreadsheet instead)

(In reply to Hsin-Yi Tsai (away for a while) [:hsinyi] from comment #1)

dom/html/test/forms/test_restore_form_elements.html
dom/html/test/forms/test_save_restore_radio_groups.html
dom/html/test/test_bug277724.html
dom/html/test/test_srcdoc-2.html
dom/tests/mochitest/bugs/test_bug593174.html
dom/tests/mochitest/dom-level1-core/test_nodesetnodevaluenomodificationallowederr.html
dom/tests/mochitest/general/test_framedhistoryframes.html

test_nodesetnodevaluenomodificationallowederr.html is failing as expected with a todo() (so it should be enabled)
Everything else depends on session history. Filed bugs.

Flags: needinfo?(bugs)

(In reply to Olli Pettay [:smaug] from comment #8)

Filed bugs.

Hi Olli, can you link those bugs here, please? Thank you!

Flags: needinfo?(bugs)
Flags: needinfo?(jstutte)
Depends on: 1657983
Depends on: 1657977
Depends on: 1657978
Depends on: 1657979
Depends on: 1657981
Depends on: 1657982
Depends on: 1659963

The updated list of failing DOM Core cross-origin Fission mochitests is below. Some of them have separate bugs filed for them already. We need to find out which tests are just test issues (can be fixed later) and which ones are feature problems that we should fix in M6b. Olli said he'll look into these.

docshell/test/mochitest/test_bug551225.html
dom/base/test/test_bug345339.html
dom/base/test/test_bug398243.html
dom/base/test/test_bug622088.html
dom/base/test/test_bug927196.html (bug 1659963)
dom/base/test/test_gsp-qualified.html
dom/html/test/forms/test_input_hasBeenTypePassword_navigation.html
dom/html/test/forms/test_restore_form_elements.html (bug 1657977)
dom/html/test/forms/test_save_restore_radio_groups.html (bug 1657978)
dom/html/test/test_bug277724.html (bug 1657979)
dom/html/test/test_srcdoc-2.html (bug 1657981)
dom/tests/mochitest/bugs/test_bug593174.html (bug 1657982)
dom/tests/mochitest/dom-level1-core/test_nodesetnodevaluenomodificationallowederr.html
dom/tests/mochitest/general/test_framedhistoryframes.html (bug 1657983)
dom/base/test/test_bug976673.html
dom/base/test/test_window_cross_origin_props.html

Flags: needinfo?(bugs)
Assignee: nobody → mbrodesser

Removing the ni?-request for smaug, because I'm looking into the bugs.

Flags: needinfo?(bugs)

:neha: "dom/base/test/test_bug976673.html" is tracked by bug 1613899, which blocks M6c (not M6b). Hence, should it be removed from #c11? Or should it block this ticket too?

Flags: needinfo?(nkochar)

:neha: "dom/base/test/test_window_cross_origin_props.html" mentioned in #c11 is already enabled for Fission. It seems, it was never disabled. Why is it on the list of #c11? Does it require special analysis?

Flags: needinfo?(jstutte)

According to comment 11 smaug is taking test_input_hasBeenTypePassword_navigation.html

Flags: needinfo?(mozilla+bmo)

Sorry, Matt, that was a typo on my part. test_input_hasBeenTypePassword_navigation.html shouldn't have been in that list.
Also, Olli is working on other Fission work. Can you help out with this test and shed some light on the cause of the failure - is it a broken functionality or a broken test?

Flags: needinfo?(mozilla+bmo)

(In reply to Mirko Brodesser (:mbrodesser) from comment #15)

:neha: "dom/base/test/test_window_cross_origin_props.html" mentioned in #c11 is already enabled for Fission. It seems, it was never disabled. Why is it on the list of #c11? Does it require special analysis?

You're right, Mirko. It's wrongly included in the spreadsheet, so we need to fix that. It is already enabled for Fission so nothing needed for this test.

Flags: needinfo?(nkochar)

(In reply to Mirko Brodesser (:mbrodesser) from comment #14)

:neha: "dom/base/test/test_bug976673.html" is tracked by bug 1613899, which blocks M6c (not M6b). Hence, should it be removed from #c11? Or should it block this ticket too?

That was in M6c, yes, but is fixed today by Henri. Anyway, to remove confusion, I've made it also in M6b.

This is the main meta bug so moving to M6c to better reflect some of the dependency bugs in M6c. See also Bug 1657982 Comment 4 for how to triage each test failure.

Fission Milestone: M6b → M6c

(In reply to Neha Kochar [:neha] from comment #17)

Sorry, Matt, that was a typo on my part. test_input_hasBeenTypePassword_navigation.html shouldn't have been in that list.
Also, Olli is working on other Fission work. Can you help out with this test and shed some light on the cause of the failure - is it a broken functionality or a broken test?

I think it's that session history isn't working properly and may be covered by bug 1467221 and/or bug 1656208.

Flags: needinfo?(mozilla+bmo)
Depends on: 1672964
Summary: Fix failing DOM core mochitests with cross-origin and Fission enabled → Fix failing DOM: Core & HTML mochitests with cross-origin and Fission enabled

Assigning this ticket to :smaug, because the only bug blocking this issue is assigned to him.

Assignee: mbrodesser → bugs
Assignee: bugs → nobody

(I don't know what blocking issue is assigned to me)

Moving this to M7 as the only remaining dependency is tracking M7.

Fission Milestone: M6c → M7
Summary: Fix failing DOM: Core & HTML mochitests with cross-origin and Fission enabled → [meta] Fix failing DOM: Core & HTML mochitests with cross-origin and Fission enabled
No longer depends on: 1672964

All of the cross-origin Fission tests have been fixed and re-enabled.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.