1652594 - Message header not updating its height properly when handling long subject line

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect, P1)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2020-07-13 14-18-46.png

The header height doesn't update properly when selecting a message with a long subject that causes multiple lines.
As you can see from the screenshot, the To line is not visible but present and cut off that area.

This seems to happen only if there's already a previously selected and visualized message with a header height attribute set.

Comment 1

[Khushil Mistry [:khushil324]]

Are you able to reproduce this issue on the trunk or is it a beta specific issue? I am not able to reproduce it on the Trunk.
We have added this function during de-grid task: https://searchfox.org/comm-central/search?q=OnResizeExpandedHeaderView&path=

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Screen record from 2020-07-14 09.12.49.gif

Yes, it's on trunk.
I was able to reproduce it consistently. The issue happens only if a previously selected message header has only 1 single line, with a very short message.
Here's a screencap.

Comment 3

[Khushil Mistry [:khushil324]]

I am not seeing this on macOS. I guess you are using Linux. When I change the message, the header portion's height is getting changed every time. If you have a macOS, can you check?

Comment 4

[Richard Marti (:Paenglab)]

With TB 78 I see this too on Windows. With Daily I don't see this on Windows. Also tried on Linux with Daily and the header expands and shows all.

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1652594_message-header-top-box-not-expanding-0.patch

Comment 6

[Khushil Mistry [:khushil324]]

Richard, can you check this with TB 78 on Windows? Also, if you have a TB 78 build on Linux.

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9163702 [details] [diff] [review]
Bug-1652594_message-header-top-box-not-expanding-0.patch

Doesn't work here.
This is a very tricky beast. I can only reproduce this between two messages. I have to narrow the window until one subject wraps. But when I narrow the window further until the From address jumps below the header buttons, the issue is no more shown. Expanding the window again shows the issue after changing the messages.

Comment 8

[Khushil Mistry [:khushil324]]

Can you debug this? We just need to call OnResizeExpandedHeaderView or tweak the function to make it work. Right now, OnResizeExpandedHeaderView gets called when we resize the messenger.xhtml or messageWindow.xhtml.

Comment 9

[Richard Marti (:Paenglab)]

I can't debug. Maybe Alessandro can.

Comment 10

[Alessandro Castellani [:aleca]]

Tricky beast indeed.
I'll see if I have some capacity to debug this later today.
Thanks Khushil for taking on this annoying issue, we'll get to the bottom of this 👍️

Comment 11

[Khushil Mistry [:khushil324]]

If you are busy then I will try on my Linux machine with Beta build. It seems that we need to call a function in the right place.

Comment 12

[Khushil Mistry [:khushil324]]

Wayne, are you able to reproduce this in any particular way?
I have tried but I am not able to reproduce this issue on MacOS 78 and daily, Linux Ubuntu 78 and daily. This is probably Windows 78 issue.

Comment 13

[Wayne Mery (:wsmwk)]

no, can't say I have seen this.

Comment 14

[Wayne Mery (:wsmwk)]

TCW can you reproduce?

Comment 15

[Arthur K. (he/him)]

Attachment: large-subject-not-cutting-off-To-field.png

(In reply to Wayne Mery (:wsmwk) from comment #14)

TCW can you reproduce?

Well, I'm testing with 84.0b here at home and I'm not seeing it there.

Comment 16

[Arthur K. (he/him)]

(In reply to Wayne Mery (:wsmwk) from comment #14)

TCW can you reproduce?

And I also tested with TB Portable 78.5.0. I'm seeing the To: field just fine with headers set to Normal.

Comment 17

[Alessandro Castellani [:aleca]]

I'm not able to reproduce this issue anymore.