Closed Bug 1652675 Opened 2 months ago Closed 2 months ago

Perma tier 2 /builds/worker/checkouts/gecko/media/libopus/celt/arm/celt_neon_intr.c:208:18: error: implicit declaration of function 'celt_inner_prod_neon' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

Categories

(Core :: Audio/Video, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: glandium)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=309697294&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dHsTN7kfTe2DaVSIC7ZTKQ/runs/0/artifacts/public/logs/live_backing.log


[task 2020-07-14T07:01:01.872Z] 07:01:01 INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/media/libopus'
[task 2020-07-14T07:01:01.872Z] 07:01:01 INFO - media/libopus/celt_neon_intr.o
[task 2020-07-14T07:01:01.877Z] 07:01:01 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang -std=gnu99 --target=aarch64-linux-gnu -o celt_neon_intr.o -c -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DOPUS_BUILD '-DOPUS_VERSION="v1.3-rc-19-g5cbd7d5f-mozilla"' -DUSE_ALLOCA -DENABLE_HARDENING -DOPUS_EXPORT= -DHAVE_LRINTF -DOPUS_ARM_PRESUME_AARCH64_NEON_INTR -DOPUS_ARM_PRESUME_NEON -DOPUS_ARM_PRESUME_NEON_INTR -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/media/libopus -I/builds/worker/workspace/obj-build/media/libopus -I/builds/worker/checkouts/gecko/media/libopus/celt -I/builds/worker/checkouts/gecko/media/libopus/include -I/builds/worker/checkouts/gecko/media/libopus/silk -I/builds/worker/checkouts/gecko/media/libopus/silk/fixed -I/builds/worker/checkouts/gecko/media/libopus/silk/float -I/builds/worker/checkouts/gecko/media/libopus/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -include /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Werror=implicit-function-declaration '-Wno-#pragma-messages' -fexperimental-new-pass-manager -MD -MP -MF .deps/celt_neon_intr.o.pp /builds/worker/checkouts/gecko/media/libopus/celt/arm/celt_neon_intr.c
[task 2020-07-14T07:01:01.877Z] 07:01:01 ERROR - /builds/worker/checkouts/gecko/media/libopus/celt/arm/celt_neon_intr.c:208:18: error: implicit declaration of function 'celt_inner_prod_neon' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
[task 2020-07-14T07:01:01.877Z] 07:01:01 INFO - xcorr[i] = celt_inner_prod_neon(_x, _y+i, len);
[task 2020-07-14T07:01:01.877Z] 07:01:01 INFO - ^
[task 2020-07-14T07:01:01.877Z] 07:01:01 INFO - /builds/worker/checkouts/gecko/media/libopus/celt/arm/celt_neon_intr.c:208:18: note: did you mean 'celt_inner_prod_c'?
[task 2020-07-14T07:01:01.877Z] 07:01:01 INFO - /builds/worker/checkouts/gecko/media/libopus/celt/arm/../pitch.h:159:31: note: 'celt_inner_prod_c' declared here
[task 2020-07-14T07:01:01.877Z] 07:01:01 INFO - static OPUS_INLINE opus_val32 celt_inner_prod_c(const opus_val16 *x,
[task 2020-07-14T07:01:01.877Z] 07:01:01 INFO - ^
[task 2020-07-14T07:01:01.877Z] 07:01:01 INFO - 1 error generated.
[task 2020-07-14T07:01:01.877Z] 07:01:01 ERROR - make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:669: celt_neon_intr.o] Error 1
[task 2020-07-14T07:01:01.877Z] 07:01:01 INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/media/libopus'
[task 2020-07-14T07:01:01.877Z] 07:01:01 ERROR - make[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: media/libopus/target-objects] Error 2
[task 2020-07-14T07:01:01.877Z] 07:01:01 INFO - make[3]: *** Waiting for unfinished jobs....
[task 2020-07-14T07:01:01.999Z] 07:01:01 INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/media/libdav1d'
[task 2020-07-14T07:01:01.999Z] 07:01:01 INFO - media/libdav1d/msac.o

Assignee: nobody → mh+mozilla

It somehow compiles fine currently without on Android, but relies on
implicit function declarations on Linux aarch64, which broke with bug
822978.

It turns out OPUS_ARM_MAY* defines are set when the OPUS_ARM_PRESUME*
ones are set at least in the cmake build system upstream, and it also
turns out that not setting them actually disables some of the neon code
(at least celt_xcorr_c ends up being used instead of celt_xcorr_neon).

Attachment #9163435 - Attachment description: Bug 1652675 - Define OPUS_ARM_MAY_HAVE_NEON{,_INTR} on aarch64. → Bug 1652675 - Define OPUS_ARM_MAY_HAVE_NEON{,_INTR} on non-android non-windows aarch64.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/1d5986a1a6da
Define OPUS_ARM_MAY_HAVE_NEON{,_INTR} on non-android non-windows aarch64. r=kinetik
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.