Closed Bug 1652741 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24587 - [webnfc] Do not support multiple scans on the same reader.

Categories

(Core :: DOM: Device Interfaces, task, P4)

Product:
Core
Component:
DOM: Device Interfaces
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24587 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24587
Details from upstream follow.

Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> wrote:

[webnfc] Do not support multiple scans on the same reader.

We added support for multiple scan invocations on the same Reader in
this CL https://chromium-review.googlesource.com/c/chromium/src/+/2145263

Since Origin Trials feedback was to remove Filtering,
spec : https://github.com/w3c/web-nfc/pull/565
WIP CL : https://chromium-review.googlesource.com/c/chromium/src/+/2225770/
we tried to reason if in a world without filtering, multiple scans on
the same Reader is needed at all. The present thinking is to simply
reject scan promise when there's already an ongoing scan.

Spec discussions: https://github.com/w3c/web-nfc/issues/592

Bug: 520391
Change-Id: Ic50873ddc30351cec6656ac7b030394dc9fa18ea
Reviewed-on: https://chromium-review.googlesource.com/2297559
WPT-Export-Revision: d3651733818a49a5e2b6dda0e7b129866ab1a6e0

Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 18 subtests

Status Summary

Firefox

OK : 2
FAIL: 35

Chrome

OK : 2
FAIL: 35

Safari

OK : 2
FAIL: 35

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/web-nfc/NDEFReader_scan.https.html
Test that NDEFReader.onerror should be fired if the NFC tag does not expose NDEF technology.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading message with multiple records should succeed.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that nfc watch success if NFC HW is enabled.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFReader.scan returns smart-poster record correctly.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if signal is not an AbortSignal.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if there is already an ongoing scan.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan matches any ids if NDEFScanOptions.id is undefined.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader can not get any reading events once the signal aborts.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that an error event happens if no implementation for NFC Mojo interface is available.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if NDEFScanOptions.signal is already aborted.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan rejects if NDEFScanOptions.signal aborts right after the scan invocation.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFRecord.toRecords returns its embedded records correctly.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFReader.scan should fail if NFC HW is disabled.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFReader.scan should fail if user permission is not granted.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.scan can be started after the previous scan is aborted.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFReader.onreading should be fired on an unformatted NFC tag with empty records array for NDEFMessage.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFReader.scan should fail if NFC HW is not supported.: FAIL (Chrome: FAIL, Safari: FAIL)
/web-nfc/NDEFReader_scan_filter.https.html
Test that reading data succeed when NDEFScanOptions' recordType is set to 'unknown'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'mime' record from different messages correctly with NDEFScanOptions' mediaType set.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading data succeed when NDEFScanOptions' recordType is set to 'text'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'empty' record from different messages correctly with NDEFScanOptions' recordType is set to 'empty'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'text' record from different messages correctly with NDEFScanOptions' id set.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering external record from different messages correctly with NDEFScanOptions' recordType is set to the custom type.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'absolute-url' record from different messages correctly with NDEFScanOptions' recordType is set to 'absolute-url'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading data succeed when NDEFScanOptions' recordType is set to 'absolute-url'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that the id of NDEFScanOptions filters relevant data sources correctly.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading data succeed when NDEFScanOptions' recordType is set to 'mime'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'url' record from different messages correctly with NDEFScanOptions' recordType is set to 'url'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that the mediaType of NDEFScanOptions filters relevant data sources correctly.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading data succeed when NDEFScanOptions' recordType is set to 'url'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading data succeed when NDEFScanOptions' recordType is set to a custom type for external type records.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that reading data succeed when NDEFScanOptions' recordType is set to 'empty'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'text' record from different messages correctly with NDEFScanOptions' recordType is set to 'text'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'mime' record from different messages correctly with NDEFScanOptions' recordType is set to 'mime'.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that filtering 'unknown' record from different messages correctly with NDEFScanOptions' recordType is set to 'unknown'.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e64f0b892b4c
[wpt PR 24587] - [webnfc] Do not support multiple scans on the same reader., a=testonly

https://hg.mozilla.org/mozilla-central/rev/e64f0b892b4c

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Regressions: 1655215
You need to log in before you can comment on or make changes to this bug.