1652746 - [Page range] Selecting the ending content of a heading tag ignores the selection rule and the rest of the document gets printed as well

Status: RESOLVED DUPLICATE of bug 1654406

(Core :: Printing: Setup, defect)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: Test Case

Affected versions

• 80.0a1 (BuildId:20200713095122)
• 79.0b7 (BuildId:20200710175519)
• 78.0.2 (BuilId:20200708170202)
• 78.0.2esr (BuildId:20200708170510)

Unaffected versions

• 68.10.0esr (BuildId:20200622191537)

Affected platforms

• Windows 10 64bit
• macOS 10.14
• Ubuntu 18.04 64bit

Steps to reproduce

1. Launch Firefox.
2. Load the attached test case.
3. Select the “Heading 1.”
4. Hit ctrl +p.
5. Click the “Selection” radio button from the “Page Range” section.
6. Print the file or save to pdf.

Expected result

• Only the selected part is printed.

Actual result

• The selected part and the rest of the content gets printed.

Regression Range

• This seems to be a regression:
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=70da3900883541dd537e508c6c4e424162f2b620&tochange=2e638f8a11df2d0d7424059abc8ae65db580cf87
• Possible Regressor: Bug 1620289

Notes

• This seems to be reproducible on other webpages as well (https://en.wikipedia.org/wiki/United_States) by selecting the ending content of a heading tag (Selecting the “history” from the “Indigenous peoples and pre-Columbian history” part).

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Erik,

It seems that mozregression pointed out Bug 1620289 - Part 1 Clone Selection Ranges For Printing r=jwatt for causing this regression.

Can you please take a look?

Thank you!

Comment 2

[Emil Ghitta, QA [:emilghitta]]

Attachment: Selection.gif

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: macOS_selection.png

Hmm, I just followed your steps on my macOS machine (which is what I wrote the initial patch on) and everything appears to work as intended. But I saw your gif of the unexpected behavior on Windows.

I'm not sure what would be causing this to behave differently on different operating systems. I will investigate this.

Comment 4

[Boris Chiou [:boris]]

I temporarily mark this as S2 because this happens on wiki (a commonly-printed site) as well, and Erik will take a look on this. Please feel free to downgrade this if there are some other workaround ways.

Comment 5

[Jonathan Watt [:jwatt]]

If I select "Heading 1" (the period is not selected) then it prints "Heading 1." (with the period). If I select "Heading 1." (with the period) it prints everything from the selection to the end of the document. The behavior of the former selection may indicate an off-by-one indexing error somewhere.