Closed Bug 1652822 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 24592 - Revert "[LayoutNG] Move relative position calculation into NG."

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24592 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24592
Details from upstream follow.

Jian Li <jianli@chromium.org> wrote:

Revert "[LayoutNG] Move relative position calculation into NG."

This reverts commit 27880cb4012f7a84f7921c1bc3f023211eb032ea.

Reason for revert:

Suspect of blink_web_tests failures in a lot of bots, like this one:

https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/70261

Unexpected Failures:

  • fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html
  • fast/css/relative-positioned-block-nested-with-inline-parent.html
  • paint/invalidation/compositing/composited-float-under-composited-inline-individual.html
  • paint/invalidation/compositing/composited-float-under-composited-inline.html
  • paint/invalidation/compositing/stacked-float-under-composited-inline.html

Original change's description:

[LayoutNG] Move relative position calculation into NG.

This patch moves the relative position calculation into NG. Previously
we needed to manually account for the relative position of an object
in many different places, overflow calculation, geometry APIs etc.

This patch directly updates the child's offset (relative to its parent)
to directly incorporate this additional offset.

This calculation occurs within the NGBoxFragmentBuilder, and if an
object is placed by LayoutNG...
...LayoutBoxModelObject::RelativePositionOffset returns an empty offset.

This fixes a few small issues where previously we didn't resolve
percentages against the correct available size when contained within
an anonymous block.

Bug: 1070822, 1058690
Change-Id: I2c623b02cc5a4605d310596f5c60353a21236bff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214608
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Xianzhu Wang \<wangxianzhu@chromium.org>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787991}

TBR=yosin@chromium.org,wangxianzhu@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org,yosin@google.com,mstensho@chromium.org

Change-Id: I5ca67701222509693d3020fa068c279cef39ecbb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1070822, 1058690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296628
Reviewed-by: Jian Li \<jianli@chromium.org>
Commit-Queue: Jian Li \<jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788228}

PR 24592 applied with additional changes from upstream: 4b32cd3ad3d262854efc7628daacb8bc2db9f06f
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e336d876852
[wpt PR 24592] - Revert "[LayoutNG] Move relative position calculation into NG.", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.