1652914 - (C11_static_assert) Replace MOZ_STATIC_ASSERT with static_assert in C code (and remove MOZ_STATIC_ASSERT)

Status: RESOLVED FIXED

(Core :: MFBT, task, P3)

Description

[Chris Peterson [:cpeterson]]

MOZ_STATIC_ASSERT is currently used only in C code, specifically in the libmar library:

https://searchfox.org/mozilla-central/rev/fa2df28a49883612bd7af4dacd80cdfedcccd2f6/modules/libmar/src/mar.h#27

https://searchfox.org/mozilla-central/rev/fa2df28a49883612bd7af4dacd80cdfedcccd2f6/modules/libmar/src/mar_private.h#30-31,35-37

static_assert is available in both C++11 and C11. While C++11's static_assert is a keyword, C11's static_assert is a macro defined in assert.h (that expands to the C11 keywoard _Static_assert). libar's header files are included in both C and C++ code, so we must #include assert.h to use static_assert.

https://en.cppreference.com/w/c/language/_Static_assert
https://en.cppreference.com/w/cpp/language/static_assert

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1652914 - Part 1: Replace MOZ_STATIC_ASSERT with static_assert in C code. r?jwalden

static_assert is available in both C++11 and C11. While C++11's static_assert is a keyword, C11's static_assert is a macro defined in assert.h (that expands to the C11 keywoard _Static_assert). libar's header files are included in both C and C++ code, so we must #include assert.h to use static_assert.

https://en.cppreference.com/w/c/language/_Static_assert

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1652914 - Part 2: Remove unused MOZ_STATIC_ASSERT macro. r?jwalden

Depends on D83736

Comment 3

[Chris Peterson [:cpeterson]]

Replacing MOZ_STATIC_ASSERT with C11's static_assert requires compiling our C code as C11 instead of C99 (bug 1653182).

Green Try build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbb5b1d93d652d655d0e95691d23dc9aebf35581

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14853017df35
Part 1: Replace MOZ_STATIC_ASSERT with static_assert in C code. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/73c606e0647d
Part 2: Remove unused MOZ_STATIC_ASSERT macro. r=jwalden

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/14853017df35
https://hg.mozilla.org/mozilla-central/rev/73c606e0647d