1653158 - moz-phab should default to -s if a single revision is specified

Status: NEW

(Conduit :: moz-phab, enhancement, P2)

Description

[Eric Rahm [:erahm]]

I'd expect moz-phab submit <rev> to only submit the given revision, currently it submits the revision and everything following it. Using -s "fixes" this, but it seems like that should be the default.

Comment 1

[:glob ✱]

The default behaviour is to submit commits between the start revision and the current commit, changing that would be a significant change to expectations.

That said, the majority submissions are single stack; while moz-phab is heavily optimised around the multiple stack use-case.

Maybe we could make this configurable, with a prompt the first time someone doesn't provide an end revision to remember the best default for that developer.

Comment 2

[Piotr Zalewa [:zalun]]

Changed priority as the impact on performance can be significant

Comment 3

[Piotr Zalewa [:zalun]]

Attachment: Bug 1653158 - Add --single automatically to single commit stacks.

Introducing Setup class which is holding settings "hidden" from the user.