Add profiler feature to control Audio Callback Tracing
Categories
(Core :: Gecko Profiler, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(3 files)
Bug 1626918 added capture of real-time audio callbacks to the profiler.
It may be the cause of some intermittents, including bug 1635619 and bug 1622477.
In a small Try test, removing Start/StopAudioCallbackTracing() calls from the profiler did seem to have an effect (not 100%, but a significant reduction in failures).
So I would like to make Audio Callback Tracing an optional feature, so that it will be off by default (except in the "Media" profiler preset), to at least help separate issues; after this we can still work on remaining intermittents, and possibly have different tests with Audio Callback Tracing enabled, so that domain experts can investigate it in isolation...
|
Assignee | |
Comment 1•4 years ago
|
||
Start/StopAudioCallbackTracing calls are always around locked_profiler_start/stop, this patch brings these calls inside the locked_ functions.
Depends on D83747
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D83748
|
|
Assignee | |
Comment 3•4 years ago
|
||
Audio Tracing Callback will be most useful when used to profile Media workloads.
Depends on D83749
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47d3860e0936 Refactor Start/StopAudioCallbackTracing calls - r=canaltinova https://hg.mozilla.org/integration/autoland/rev/03987b9cf16f Profiler feature 'audiocallbacktracing' controls Start/StopAudioCallbackTracing(), off by default - r=canaltinova https://hg.mozilla.org/integration/autoland/rev/5bbc99899f45 Enable Audio Callback Tracing in Media preset - r=canaltinova
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/47d3860e0936
https://hg.mozilla.org/mozilla-central/rev/03987b9cf16f
https://hg.mozilla.org/mozilla-central/rev/5bbc99899f45
Description
•